Build the "in build" crossgen2 into a pack that we can use within the VMR #110676
Conversation
…in-build host-targeting crossgen2.
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
…st the AOT-in-build logic to handle AOT-ing for the host.
…ary and it breaks the new crossgen2 host package
…time is the last repo.
…gen2 tasks in the SDK to discover the target OS from the source-build target RID
There was a problem hiding this comment.
All changes in this file are a workaround until the bootstrap SDK for source-build has dotnet/sdk#45566 included.
src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Crossgen2.props
Outdated
Show resolved
Hide resolved
…lishing to publish packages as packages.
| @@ -1,6 +1,6 @@ | |||
| <Project> | |||
| <PropertyGroup> | |||
| <EnableDefaultArtifacts Condition="'$(DotNetBuild)' != 'true'">false</EnableDefaultArtifacts> | |||
| <EnableDefaultArtifacts>false</EnableDefaultArtifacts> | |||
There was a problem hiding this comment.
Why can't we use default artifact lookup here anymore and then just update the items and put the Visibility metadata on them?
There was a problem hiding this comment.
By the time we can hook a target in, NuGet packages have already been added to the ItemsToPushToBlobFeed item group, which as far as I can tell is not a "documented" repo extension point. We can't manipulate it through the Artifact item group. I can likely change this to try to catch it and its symbol package midway through in that group and adjust it.
There was a problem hiding this comment.
Why do we need a target? Can't we do this at evaluation time?
There was a problem hiding this comment.
If we do it in evaluation I think we'd end up with duplicate entries as the "default" artifacts globbing for packages doesn't take any efforts to avoid Artifact items.
There was a problem hiding this comment.
I see what you mean. I think we should allow to exclude items from the glob when using default artifacts, in these two places:
- https://github.com/dotnet/arcade/blob/ccae251ef033746eb0213329953f5e3c1687693b/src/Microsoft.DotNet.Arcade.Sdk/tools/Sign.props#L28-L36
- https://github.com/dotnet/arcade/blob/ccae251ef033746eb0213329953f5e3c1687693b/src/Microsoft.DotNet.Arcade.Sdk/tools/Publish.proj#L109-L115
Something like <ExcludedArtifact Include="$(ArtifactsPackagesDir)**\Microsoft.NETCore.App.Crossgen2.$(NETCoreSdkRuntimeIdentifier).*.nupkg" />
We should rely on Arcade's default artifacts globbing. I imagine that we will add more items to the default globbing list with the ongoing signing work. I expect that we will update Arcade's default globbing list so that it automatically respects all these different artifacts so that we don't have to define them in individual repos like windowsdesktop, aspnetcore, runtime, sdk, etc.
| <!-- Workaround for https://github.com/dotnet/sdk/pull/45566: Ensure that the OS portion of the RID we're building for is part of the RID graph as a separate RID. --> | ||
| <PropertyGroup Condition="'$(DotNetBuildSourceOnly)' == 'true'"> | ||
| <OutputRidOS Condition="$(OutputRID.Contains('-'))">$(OutputRID.Split('-')[0])</OutputRidOS> | ||
| <AdditionalRidParentOS Condition="$(AdditionalRuntimeIdentifierParent.Contains('-'))">$(AdditionalRuntimeIdentifierParent.Split('-')[0])</AdditionalRidParentOS> | ||
| <AdditionalRidParentOS Condition="!$(AdditionalRuntimeIdentifierParent.Contains('-'))">$(AdditionalRuntimeIdentifierParent)</AdditionalRidParentOS> | ||
| </PropertyGroup> |
There was a problem hiding this comment.
Is the entire property group the workaround? When will we be able to remove this?
There was a problem hiding this comment.
Is the L36 (with your changes) also temporary?
For the same reasons that we need an "in build" crossgen2 in dotnet/runtime, we need one in the VMR for cross-builds of downstream repos (like aspnetcore).
Opening as draft until I can get enough pieces together to validate the end-to-end experience. This will need changes in aspnetcore, windowsdesktop, sdk, and the orchestration for dotnet/runtime (to put the host crossgen2 package in a place where it won't accidentally get off the machine or cause conflicts in asset selection).
Contributes to dotnet/source-build#3793