Simplify usage of the installer and shared framework SDKs based on improvements in the tooling #109710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…provements in the tooling
1 task
jkoritzinsky
added a commit
to jkoritzinsky/arcade
that referenced
this pull request
Dec 5, 2024
jkoritzinsky
added a commit
to jkoritzinsky/arcade
that referenced
this pull request
Dec 5, 2024
jkoritzinsky
added a commit
to jkoritzinsky/runtime
that referenced
this pull request
Dec 12, 2024
ViktorHofer
approved these changes
Dec 20, 2024
ViktorHofer
added a commit
that referenced
this pull request
Jan 10, 2025
… VMR (#110676) * Add a new crossgen2 build variant for a published crossgen2 targetting the host OS * Remove the .NET-hosted in-build crossgen2 and just use the published in-build host-targeting crossgen2. * Extract crossgen2 sfxproj changes from #109710 * Extract the properties and targets that will be shared into a separate props file. * Add a "host crossgen2" project * Add the crossgen2 host package to Subsets.props for the correct scenarios. * Fix crossgen-corelib to work with the new in-build crossgen2 * Publish the in-build crossgen2 as single file to avoid having to adjust the AOT-in-build logic to handle AOT-ing for the host. * AOT on Windows only * Don't set Platform for the shared framework projects. It's not necessary and it breaks the new crossgen2 host package * Forward ShortStack down so we don't build the host crossgen2 when runtime is the last repo. * Add os-only RID to portable RID graph in source-build to enable crossgen2 tasks in the SDK to discover the target OS from the source-build target RID * Publish the host crossgen2 as a "Vertical" visibility asset. * Cleanup crossgen2 infra, add comment about workaround, and adjust publishing to publish packages as packages. * Deduplicate artifacts * Add back the Update, somehow this got lost. * Don't forward down ShortStack * Use new "update" functionality to specify which artifacts are vertical visibility * Revert changes to Signing.props * Remove workaround now that the VMR has a bootstrap SDK with a new enough version. --------- Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires dotnet/arcade#15239
Requires dotnet/arcade#15295