[RISC-V] Fix Int32 to Unsigned overflow check #107024

Bajtazar · 2024-08-27T09:20:14Z

Fixes int to uint and int to ulong convertion overflow check on RISC-V. Previously the blt a0, zero, RAISE_OVERFLOW was generated, but the integer inside the source register was not sign extended resulting in this check always passing. The sign extending instruction was added before the branch in order to properly sign extend the incoming integer
Added ret pseudoinstruction to RISC-V disasm
Improved disasm of j pseudoinstruction
Optimized other integer casts a little bit

Part of #84834, cc @dotnet/samsung

dotnet-policy-service · 2024-08-27T09:22:44Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

src/coreclr/jit/instr.cpp

…/runtime into riscv-positive-int-overflow-fix

This reverts commit 144629f.

src/coreclr/jit/instr.cpp

src/coreclr/jit/codegenriscv64.cpp

tomeksowi · 2024-08-27T09:43:08Z

the integer inside the source register was not sign extended

Where did the unextended int come from?

src/coreclr/jit/codegenriscv64.cpp

Bajtazar · 2024-08-27T14:06:16Z

src/coreclr/jit/codegenriscv64.cpp

        case GenIntCastDesc::CHECK_POSITIVE:
        {
-            genJumpToThrowHlpBlk_la(SCK_OVERFLOW, INS_blt, reg, nullptr, REG_R0);


If I am correct this piece of code is invoked during uint -> int conversion. That would mean that if the uint > 0x7f'ff'ff'ff the old comparation wouldn't work since it wouldn't be classified as an overflow

risc-vv · 2024-08-29T10:10:55Z

RISC-V Release-CLR-QEMU: 9391 / 9410 (99.80%)

=======================
      passed: 9391
      failed: 3
     skipped: 107
      killed: 16
------------------------
  TOTAL libs: 9517
 TOTAL tests: 9517
   REAL time: 57min 54s 595ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

RISC-V Release-FX-QEMU: 633385 / 647115 (97.88%)

=======================
      passed: 633385
      failed: 318
     skipped: 1773
      killed: 13412
------------------------
  TOTAL libs: 256
 TOTAL tests: 648888
   REAL time: 1h 10min 21s 22ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and links

GIT: 5fdc67f20569fe496fb86a68820f949259f26f85
CI: 529268ece23d4da7be41ac937cc8f4a2e344e67b
REPO: Bajtazar/runtime
BRANCH: riscv-positive-int-overflow-fix
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG
# TESTCLR_RUN
/go-agent/pipelines/Release-CLR-QEMU/logs/run_tests.log
cd "/_PATH_/_WITH_/_TEST_" && ROOTFS_DIR=/crossrootfs/riscv64 QEMU_LD_PREFIX=/crossrootfs/riscv64 __TestDotNetCmd=/go-agent/pipelines/Release-CLR-QEMU/testhost.Release/dotnet CORE_ROOT=/go-agent/pipelines/Release-CLR-QEMU/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --corefx --testhost ./testhost.Release --atest ./corefx.Release --log_dir ./logs  --timeout 6000 --memlimit 4096 --jobs 16 --log_level DEBUG --xunit xunit.Release
# TESTFX_RUN
/godata/pipelines/Release-FX-QEMU/logs/run_tests.log
cp -R "/godata/pipelines/Release-FX-QEMU/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ &&cd "/_PATH_/_WITH_/_TEST_" && ROOTFS_DIR=/crossrootfs/riscv64 QEMU_LD_PREFIX=/crossrootfs/riscv64 __TestDotNetCmd=/godata/pipelines/Release-FX-QEMU/testhost.Release/dotnet  /usr/bin/time -f "exec_time: %e" /godata/pipelines/Release-FX-QEMU/testhost.Release/dotnet exec   xunit.console.dll _TEST_BINARY_ -nologo -nocolor -notrait category=failing

RISC-V Release-CLR-VF2: 9394 / 9410 (99.83%)

=======================
      passed: 9394
      failed: 1
     skipped: 107
      killed: 15
------------------------
  TOTAL libs: 9517
 TOTAL tests: 9517
   REAL time: 3h 0min 59s 444ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

RISC-V Release-FX-VF2: 547689 / 594393 (92.14%)

=======================
      passed: 547689
      failed: 22
     skipped: 1509
      killed: 46682
------------------------
  TOTAL libs: 256
 TOTAL tests: 595902
   REAL time: 2h 28min 41s 317ms
=======================

Release-FX-VF2.md, Release-FX-VF2.xml, testfx_output.tar.gz

Build information and links

GIT: 5fdc67f20569fe496fb86a68820f949259f26f85
CI: 529268ece23d4da7be41ac937cc8f4a2e344e67b
REPO: Bajtazar/runtime
BRANCH: riscv-positive-int-overflow-fix
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG
# TESTCLR_RUN
/var/lib/go-agent/pipelines/Release-CLR-VF2/logs/run_tests.log
cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-CLR-VF2/testhost.Release/dotnet CORE_ROOT=/var/lib/go-agent/pipelines/Release-CLR-VF2/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --corefx --testhost ./testhost.Release --atest ./corefx.Release --log_dir ./logs  --timeout 6000 --memlimit 4096 --jobs 8 --log_level DEBUG --xunit xunit.Release
# TESTFX_RUN
/var/lib/go-agent/pipelines/Release-FX-VF2/logs/run_tests.log
cp -R "/var/lib/go-agent/pipelines/Release-FX-VF2/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ &&cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-FX-VF2/testhost.Release/dotnet  /usr/bin/time -f "exec_time: %e" /var/lib/go-agent/pipelines/Release-FX-VF2/testhost.Release/dotnet exec   xunit.console.dll _TEST_BINARY_ -nologo -nocolor -notrait category=failing

RISC-V Release-CLR-QEMU: 9392 / 9411 (99.80%)

=======================
      passed: 9392
      failed: 3
     skipped: 107
      killed: 16
------------------------
  TOTAL libs: 9518
 TOTAL tests: 9518
   REAL time: 57min 52s 596ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

RISC-V Release-FX-QEMU: 633385 / 647115 (97.88%)

=======================
      passed: 633385
      failed: 318
     skipped: 1773
      killed: 13412
------------------------
  TOTAL libs: 256
 TOTAL tests: 648888
   REAL time: 1h 10min 21s 22ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and links

GIT: 5fdc67f20569fe496fb86a68820f949259f26f85
CI: 529268ece23d4da7be41ac937cc8f4a2e344e67b
REPO: Bajtazar/runtime
BRANCH: riscv-positive-int-overflow-fix
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG
# TESTCLR_RUN
/go-agent/pipelines/Release-CLR-QEMU/logs/run_tests.log
cd "/_PATH_/_WITH_/_TEST_" && ROOTFS_DIR=/crossrootfs/riscv64 QEMU_LD_PREFIX=/crossrootfs/riscv64 __TestDotNetCmd=/go-agent/pipelines/Release-CLR-QEMU/testhost.Release/dotnet CORE_ROOT=/go-agent/pipelines/Release-CLR-QEMU/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --corefx --testhost ./testhost.Release --atest ./corefx.Release --log_dir ./logs  --timeout 6000 --memlimit 4096 --jobs 16 --log_level DEBUG --xunit xunit.Release
# TESTFX_RUN
/godata/pipelines/Release-FX-QEMU/logs/run_tests.log
cp -R "/godata/pipelines/Release-FX-QEMU/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ &&cd "/_PATH_/_WITH_/_TEST_" && ROOTFS_DIR=/crossrootfs/riscv64 QEMU_LD_PREFIX=/crossrootfs/riscv64 __TestDotNetCmd=/godata/pipelines/Release-FX-QEMU/testhost.Release/dotnet  /usr/bin/time -f "exec_time: %e" /godata/pipelines/Release-FX-QEMU/testhost.Release/dotnet exec   xunit.console.dll _TEST_BINARY_ -nologo -nocolor -notrait category=failing

risc-vv · 2024-09-03T11:01:10Z

209a8b1 is being scheduled for building and testing

GIT: 209a8b16d938c9a7d723c4c45a8e7acb4d15ce0a
REPO: dotnet/runtime
BRANCH: main

Release-CLR-build FAILED

buildinfo.json
${{details}}

src/coreclr/jit/emitriscv64.cpp

src/coreclr/jit/codegenriscv64.cpp

risc-vv · 2024-09-03T14:01:04Z

97c951c is being scheduled for building and testing

GIT: 97c951c6832b702b0ebf7808c06e0073beb1c0e6
REPO: dotnet/runtime
BRANCH: main

Release-CLR-build FAILED

buildinfo.json
${{details}}

risc-vv · 2024-09-04T12:31:07Z

RISC-V Release-CLR-QEMU: 9397 / 9414 (99.82%)

=======================
      passed: 9397
      failed: 2
     skipped: 107
      killed: 15
------------------------
  TOTAL libs: 9521
 TOTAL tests: 9521
   REAL time: 47min 21s 138ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

RISC-V Release-FX-QEMU: 543389 / 579391 (93.79%)

=======================
      passed: 543389
      failed: 330
     skipped: 1456
      killed: 35672
------------------------
  TOTAL libs: 256
 TOTAL tests: 580847
   REAL time: 1h 48min 55s 492ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and links

GIT: daa73aa37617aa118b1a4dde3d3bc3a20619476a
CI: 7e8a0f59ee23fd1242925c55e405749bc144832d
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG
# TESTCLR_RUN
/godata/pipelines/Release-CLR-QEMU/logs/run_tests.log
cd "/_PATH_/_WITH_/_TEST_" && ROOTFS_DIR=/crossrootfs/riscv64 QEMU_LD_PREFIX=/crossrootfs/riscv64 __TestDotNetCmd=/godata/pipelines/Release-CLR-QEMU/testhost.Release/dotnet CORE_ROOT=/godata/pipelines/Release-CLR-QEMU/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --corefx --testhost ./testhost.Release --atest ./corefx.Release --log_dir ./logs  --timeout 6000 --memlimit 4096 --jobs 16 --log_level DEBUG --xunit xunit.Release
# TESTFX_RUN
/godata/pipelines/Release-FX-QEMU/logs/run_tests.log
cp -R "/godata/pipelines/Release-FX-QEMU/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ &&cd "/_PATH_/_WITH_/_TEST_" && ROOTFS_DIR=/crossrootfs/riscv64 QEMU_LD_PREFIX=/crossrootfs/riscv64 __TestDotNetCmd=/godata/pipelines/Release-FX-QEMU/testhost.Release/dotnet  /usr/bin/time -f "exec_time: %e" /godata/pipelines/Release-FX-QEMU/testhost.Release/dotnet exec   xunit.console.dll _TEST_BINARY_ -nologo -nocolor -notrait category=failing

RISC-V Release-CLR-VF2: 9398 / 9414 (99.83%)

=======================
      passed: 9398
      failed: 1
     skipped: 107
      killed: 15
------------------------
  TOTAL libs: 9521
 TOTAL tests: 9521
   REAL time: 3h 2min 3s 536ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

RISC-V Release-FX-VF2: 495750 / 549712 (90.18%)

=======================
      passed: 495750
      failed: 18
     skipped: 1457
      killed: 53944
------------------------
  TOTAL libs: 256
 TOTAL tests: 551169
   REAL time: 3h 6min 18s 29ms
=======================

Release-FX-VF2.md, Release-FX-VF2.xml, testfx_output.tar.gz

Build information and links

GIT: daa73aa37617aa118b1a4dde3d3bc3a20619476a
CI: 7e8a0f59ee23fd1242925c55e405749bc144832d
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG
# TESTCLR_RUN
/var/lib/go-agent/pipelines/Release-CLR-VF2/logs/run_tests.log
cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-CLR-VF2/testhost.Release/dotnet CORE_ROOT=/var/lib/go-agent/pipelines/Release-CLR-VF2/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --corefx --testhost ./testhost.Release --atest ./corefx.Release --log_dir ./logs  --timeout 6000 --memlimit 4096 --jobs 8 --log_level DEBUG --xunit xunit.Release
# TESTFX_RUN
/var/lib/go-agent/pipelines/Release-FX-VF2/logs/run_tests.log
cp -R "/var/lib/go-agent/pipelines/Release-FX-VF2/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ &&cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-FX-VF2/testhost.Release/dotnet  /usr/bin/time -f "exec_time: %e" /var/lib/go-agent/pipelines/Release-FX-VF2/testhost.Release/dotnet exec   xunit.console.dll _TEST_BINARY_ -nologo -nocolor -notrait category=failing

RISC-V Release-CLR-QEMU: 9397 / 9414 (99.82%)

=======================
      passed: 9397
      failed: 2
     skipped: 107
      killed: 15
------------------------
  TOTAL libs: 9521
 TOTAL tests: 9521
   REAL time: 45min 55s 86ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

RISC-V Release-FX-QEMU: 543389 / 579391 (93.79%)

=======================
      passed: 543389
      failed: 330
     skipped: 1456
      killed: 35672
------------------------
  TOTAL libs: 256
 TOTAL tests: 580847
   REAL time: 1h 48min 55s 492ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and links

GIT: daa73aa37617aa118b1a4dde3d3bc3a20619476a
CI: 7e8a0f59ee23fd1242925c55e405749bc144832d
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG
# TESTCLR_RUN
/godata/pipelines/Release-CLR-QEMU/logs/run_tests.log
cd "/_PATH_/_WITH_/_TEST_" && ROOTFS_DIR=/crossrootfs/riscv64 QEMU_LD_PREFIX=/crossrootfs/riscv64 __TestDotNetCmd=/godata/pipelines/Release-CLR-QEMU/testhost.Release/dotnet CORE_ROOT=/godata/pipelines/Release-CLR-QEMU/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --corefx --testhost ./testhost.Release --atest ./corefx.Release --log_dir ./logs  --timeout 6000 --memlimit 4096 --jobs 16 --log_level DEBUG --xunit xunit.Release
# TESTFX_RUN
/godata/pipelines/Release-FX-QEMU/logs/run_tests.log
cp -R "/godata/pipelines/Release-FX-QEMU/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ &&cd "/_PATH_/_WITH_/_TEST_" && ROOTFS_DIR=/crossrootfs/riscv64 QEMU_LD_PREFIX=/crossrootfs/riscv64 __TestDotNetCmd=/godata/pipelines/Release-FX-QEMU/testhost.Release/dotnet  /usr/bin/time -f "exec_time: %e" /godata/pipelines/Release-FX-QEMU/testhost.Release/dotnet exec   xunit.console.dll _TEST_BINARY_ -nologo -nocolor -notrait category=failing

RISC-V Release-CLR-QEMU: 9397 / 9414 (99.82%)

=======================
      passed: 9397
      failed: 2
     skipped: 107
      killed: 15
------------------------
  TOTAL libs: 9521
 TOTAL tests: 9521
   REAL time: 46min 13s 431ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

RISC-V Release-FX-QEMU: 543389 / 579391 (93.79%)

=======================
      passed: 543389
      failed: 330
     skipped: 1456
      killed: 35672
------------------------
  TOTAL libs: 256
 TOTAL tests: 580847
   REAL time: 1h 48min 55s 492ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and links

GIT: daa73aa37617aa118b1a4dde3d3bc3a20619476a
CI: 7e8a0f59ee23fd1242925c55e405749bc144832d
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG
# TESTCLR_RUN
/godata/pipelines/Release-CLR-QEMU/logs/run_tests.log
cd "/_PATH_/_WITH_/_TEST_" && ROOTFS_DIR=/crossrootfs/riscv64 QEMU_LD_PREFIX=/crossrootfs/riscv64 __TestDotNetCmd=/godata/pipelines/Release-CLR-QEMU/testhost.Release/dotnet CORE_ROOT=/godata/pipelines/Release-CLR-QEMU/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --corefx --testhost ./testhost.Release --atest ./corefx.Release --log_dir ./logs  --timeout 6000 --memlimit 4096 --jobs 16 --log_level DEBUG --xunit xunit.Release
# TESTFX_RUN
/godata/pipelines/Release-FX-QEMU/logs/run_tests.log
cp -R "/godata/pipelines/Release-FX-QEMU/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ &&cd "/_PATH_/_WITH_/_TEST_" && ROOTFS_DIR=/crossrootfs/riscv64 QEMU_LD_PREFIX=/crossrootfs/riscv64 __TestDotNetCmd=/godata/pipelines/Release-FX-QEMU/testhost.Release/dotnet  /usr/bin/time -f "exec_time: %e" /godata/pipelines/Release-FX-QEMU/testhost.Release/dotnet exec   xunit.console.dll _TEST_BINARY_ -nologo -nocolor -notrait category=failing

RISC-V Release-CLR-VF2: 9398 / 9414 (99.83%)

=======================
      passed: 9398
      failed: 1
     skipped: 107
      killed: 15
------------------------
  TOTAL libs: 9521
 TOTAL tests: 9521
   REAL time: 2h 58min 2s 154ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

RISC-V Release-FX-VF2: 495750 / 549712 (90.18%)

=======================
      passed: 495750
      failed: 18
     skipped: 1457
      killed: 53944
------------------------
  TOTAL libs: 256
 TOTAL tests: 551169
   REAL time: 3h 6min 18s 29ms
=======================

Release-FX-VF2.md, Release-FX-VF2.xml, testfx_output.tar.gz

Build information and links

GIT: daa73aa37617aa118b1a4dde3d3bc3a20619476a
CI: 7e8a0f59ee23fd1242925c55e405749bc144832d
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG
# TESTCLR_RUN
/var/lib/go-agent/pipelines/Release-CLR-VF2/logs/run_tests.log
cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-CLR-VF2/testhost.Release/dotnet CORE_ROOT=/var/lib/go-agent/pipelines/Release-CLR-VF2/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --corefx --testhost ./testhost.Release --atest ./corefx.Release --log_dir ./logs  --timeout 6000 --memlimit 4096 --jobs 8 --log_level DEBUG --xunit xunit.Release
# TESTFX_RUN
/var/lib/go-agent/pipelines/Release-FX-VF2/logs/run_tests.log
cp -R "/var/lib/go-agent/pipelines/Release-FX-VF2/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ &&cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-FX-VF2/testhost.Release/dotnet  /usr/bin/time -f "exec_time: %e" /var/lib/go-agent/pipelines/Release-FX-VF2/testhost.Release/dotnet exec   xunit.console.dll _TEST_BINARY_ -nologo -nocolor -notrait category=failing

Bajtazar · 2024-09-13T07:52:03Z

@jakobbotsch @jkotas Could you please merge this? I don't think there is anything more left to address in this PR

Bajtazar added 7 commits August 26, 2024 16:35

[RISC-V] Allowed CHECK_POSITIVE to have temporary register

b112859

[RISC-V] Fixed CHECK_POSITIVE in genIntCastOverflowCheck

f3fb8b3

[RISC-V] Improved J pseudoinstruction printing

9054a4e

[RISC-V] Added ret pseudoinstruction to disasm

1f7c669

[RISC-V] Fixed register type in disasm

4dcc555

[RISC-V] Fixed ins_Load

144629f

[RISC-V] Formatted code

0a595fb

dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 27, 2024

dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 27, 2024

Merge branch 'main' into riscv-positive-int-overflow-fix

87105a9

clamp03 assigned Bajtazar Aug 27, 2024

clamp03 added the arch-riscv Related to the RISC-V architecture label Aug 27, 2024

jakobbotsch reviewed Aug 27, 2024

View reviewed changes

src/coreclr/jit/instr.cpp Outdated Show resolved Hide resolved

Bajtazar added 4 commits August 27, 2024 11:36

[RISC-V] Fixed format bug

c68c1cd

Merge branch 'riscv-positive-int-overflow-fix' of github.com:Bajtazar…

9b268e9

…/runtime into riscv-positive-int-overflow-fix

Revert "[RISC-V] Fixed ins_Load"

bd678ee

This reverts commit 144629f.

[RISC-V] Fixed comment in codegenlinear

4bef7fb

tomeksowi reviewed Aug 27, 2024

View reviewed changes

src/coreclr/jit/instr.cpp Outdated Show resolved Hide resolved

src/coreclr/jit/codegenriscv64.cpp Outdated Show resolved Hide resolved

tomeksowi reviewed Aug 27, 2024

View reviewed changes

src/coreclr/jit/codegenriscv64.cpp Outdated Show resolved Hide resolved

Bajtazar added 7 commits August 27, 2024 12:53

[RISC-V] Fixed sextw attribute type

eea0be5

[RISC-V] Simplified casts logic

cdb7924

[RISC-V] Improved CHECK_SMALL_INT_RANGE casts

1b4907e

[RISC-V] Optimized check int range

d063b64

[RISC-V] Fixes in codegenriscv64

4dffd5f

[RISC-V] Removed unused comment

74868f2

[RISC-V] Fixed long/ulong casts

bc09d23

Bajtazar commented Aug 27, 2024

View reviewed changes

[RISC-V] Added some comments

44e7411

build-analysis bot mentioned this pull request Aug 27, 2024

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

3 tasks

Bajtazar added 3 commits August 28, 2024 12:50

[RISC-V] Fixes in CHECK_SMALL_INT_RANGE

75d7405

[RISC-V] More bugfixes in int casts

eba998a

[RISC-V] Generalized CHECK_SMALL_INT_RANGE a little bit

5fdc67f

Merge branch 'main' into riscv-positive-int-overflow-fix

209a8b1

Bajtazar marked this pull request as ready for review September 3, 2024 10:57

tomeksowi approved these changes Sep 3, 2024

View reviewed changes

clamp03 reviewed Sep 3, 2024

View reviewed changes

src/coreclr/jit/emitriscv64.cpp Show resolved Hide resolved

clamp03 reviewed Sep 3, 2024

View reviewed changes

src/coreclr/jit/codegenriscv64.cpp Outdated Show resolved Hide resolved

Bajtazar added 2 commits September 3, 2024 15:57

[RISC-V] Fixed typo

5db2482

Merge branch 'main' into riscv-positive-int-overflow-fix

97c951c

clamp03 approved these changes Sep 3, 2024

View reviewed changes

build-analysis bot mentioned this pull request Sep 3, 2024

restarted. Azure DevOps can't recover from restarts. dotnet/dnceng#3879

Open

3 tasks

yurai007 approved these changes Sep 4, 2024

View reviewed changes

Merge branch 'main' into riscv-positive-int-overflow-fix

daa73aa

sirntar approved these changes Sep 5, 2024

View reviewed changes

build-analysis bot mentioned this pull request Sep 11, 2024

System.Numerics.Tensors.Tests.TensorSpanTests.TensorExtensionsTwoSpanInFloatOut fails with IndexOutOfRangeException #107254

Open

jkotas requested a review from jakobbotsch September 13, 2024 16:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RISC-V] Fix Int32 to Unsigned overflow check #107024

[RISC-V] Fix Int32 to Unsigned overflow check #107024

Bajtazar commented Aug 27, 2024 •

edited

Loading

dotnet-policy-service bot commented Aug 27, 2024

tomeksowi commented Aug 27, 2024

Bajtazar Aug 27, 2024 •

edited

Loading

risc-vv commented Aug 29, 2024 •

edited

Loading

risc-vv commented Sep 3, 2024 •

edited

Loading

risc-vv commented Sep 3, 2024 •

edited

Loading

risc-vv commented Sep 4, 2024 •

edited

Loading

Bajtazar commented Sep 13, 2024

[RISC-V] Fix Int32 to Unsigned overflow check #107024

Are you sure you want to change the base?

[RISC-V] Fix Int32 to Unsigned overflow check #107024

Conversation

Bajtazar commented Aug 27, 2024 • edited Loading

dotnet-policy-service bot commented Aug 27, 2024

tomeksowi commented Aug 27, 2024

Bajtazar Aug 27, 2024 • edited Loading

Choose a reason for hiding this comment

risc-vv commented Aug 29, 2024 • edited Loading

risc-vv commented Sep 3, 2024 • edited Loading

risc-vv commented Sep 3, 2024 • edited Loading

risc-vv commented Sep 4, 2024 • edited Loading

Bajtazar commented Sep 13, 2024

Bajtazar commented Aug 27, 2024 •

edited

Loading

Bajtazar Aug 27, 2024 •

edited

Loading

risc-vv commented Aug 29, 2024 •

edited

Loading

risc-vv commented Sep 3, 2024 •

edited

Loading

risc-vv commented Sep 3, 2024 •

edited

Loading

risc-vv commented Sep 4, 2024 •

edited

Loading