[release/8.0-staging] [workloads] Don't load mono librarymode targets if PublishAot is set #103817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This change removes the incorrect error message when you using NativeAOT library mode on mobile and you have `<NativeLib>` set. Previously, it would only detect if `<NativeLib>` was set and error out if you didn't install the library builder workload. That only applies if mono is your target.
|
Tagging subscribers to this area: @directhex, @matouskozak |
mangod9
approved these changes
Jun 24, 2024
jeffschwMSFT
approved these changes
Jul 2, 2024
rbhanda
added
Servicing-approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #103777 to release/8.0-staging
/cc @steveisok
Customer Impact
Customers who want to create native static or shared libraries (aka library mode) for nativeaot targeting ios and android are blocked by an msbuild check in the mono workload target. This check assumes if you set the
NativeLibproperty that you want mono's version of library mode and it will error out telling you to install a specific workload.The fix adds an additional check for
PublishAot != 'true'to prevent the error message from appearing when the customer wants nativeaot.Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
Tested a local project that was able to produce a native library
Risk
Low
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.