[workloads] Don't load mono librarymode targets if PublishAot is set #103777
Conversation
This change removes the incorrect error message when you using NativeAOT library mode on mobile and you have `<NativeLib>` set. Previously, it would only detect if `<NativeLib>` was set and error out if you didn't install the library builder workload. That only applies if mono is your target.
|
Tagging subscribers to this area: @directhex, @matouskozak |
There was a problem hiding this comment.
LGTM, thanks!
@steveisok, as we are getting closer to remove the experimental flag from this feature, I think we should consider adding some E2E tests in dotnet/sdk to validate the behaviour. I can open a tracking issue for it if you agree?
|
/backport to release/8.0-staging |
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/9614699845 |
yeah, I think that's fine. |
…otnet#103777) This change removes the incorrect error message when you using NativeAOT library mode on mobile and you have `<NativeLib>` set. Previously, it would only detect if `<NativeLib>` was set and error out if you didn't install the library builder workload. That only applies if mono is your target.
|
Opened dotnet/sdk#42064 for tracking |
|
Hi! |
|
Yes this will be part of preview7 |
This change removes the incorrect error message when using NativeAOT library mode on mobile and you have
<NativeLib>set. Previously, it would only detect if<NativeLib>was set and error out if you didn't have the library builder workload installed. That only applies if mono is your target.