Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unix throws the wrong exception creating a FileStream #21801

Closed
JeremyKuhne opened this issue May 19, 2017 · 6 comments
Closed

Unix throws the wrong exception creating a FileStream #21801

JeremyKuhne opened this issue May 19, 2017 · 6 comments
Assignees
@JeremyKuhne
Labels
area-System.IO
Milestone
2.0.0

Comments

@JeremyKuhne
Copy link
Member

Same underlying issue as #21745. Need to update CoreLib to throw DirectoryNotFound if the directory doesn't exist. (/directory/doesnotexist/doesnotexist)
@JeremyKuhne JeremyKuhne self-assigned this May 19, 2017
JeremyKuhne referenced this issue in JeremyKuhne/corefx May 22, 2017
@JeremyKuhne
Associate #19965 with existing test
202c1d6 
There is a PR to fix the behavior in FileStream in CoreCLR. This
test will pass as per the Windows OS block once that change is taken.
Disabling and tracking to allow taking a new drop.
JeremyKuhne referenced this issue in dotnet/corefx May 22, 2017
@JeremyKuhne
Associate #19965 with existing test (#20111)
4a62cf8 
There is a PR to fix the behavior in FileStream in CoreCLR. This
test will pass as per the Windows OS block once that change is taken.
Disabling and tracking to allow taking a new drop.
JeremyKuhne referenced this issue in JeremyKuhne/corefx May 22, 2017
@JeremyKuhne
Associate #19965 with existing test (dotnet#20111)
8568aaa 
There is a PR to fix the behavior in FileStream in CoreCLR. This
test will pass as per the Windows OS block once that change is taken.
Disabling and tracking to allow taking a new drop.
JeremyKuhne referenced this issue in dotnet/corefx May 23, 2017
@JeremyKuhne
Associate #19965 with existing test (#20111)
09d0809 
There is a PR to fix the behavior in FileStream in CoreCLR. This
test will pass as per the Windows OS block once that change is taken.
Disabling and tracking to allow taking a new drop.
@JeremyKuhne
Copy link
Member Author

Corelib is updated, need to remove the skips when we take the next drop.

@karelz
Copy link
Member

karelz commented May 30, 2017

Reopening to track port to rel/2.0.0 branch.

@karelz karelz reopened this May 30, 2017
@stephentoub
Copy link
Member

stephentoub commented May 30, 2017 •
edited
Loading

@karelz, the actual fix is already in the rel/2.0 branch, no? The only thing I did and that closed this was re-enabling tests in master. You're reopening this to track re-enabling those tests in 2.0 as well?

@karelz
Copy link
Member

karelz commented May 30, 2017

I don't see any PR in this issue against rel/2.0.0 branch. If there is one, let's link them properly.

@karelz
Copy link
Member

karelz commented May 30, 2017

I let you as experts decide if we need to re-enable the tests in rel/2.0.0 branch. If there is value, I'd suggest to do it.

@JeremyKuhne
Copy link
Member Author

I'll open a separate issue for porting the test.

dotnet/coreclr#11757 fixed this in CoreCLR for master.
dotnet/coreclr#11807 ported the CoreCLR fix.

@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 2.0.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JeremyKuhne JeremyKuhne

Labels
area-System.IO
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
4 participants
@stephentoub @karelz @JeremyKuhne @msftgits