This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Update Unix SafeHandle to throw NotFound correctly (#11757) #11807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update Unix SafeHandle to throw NotFound correctly Need to match Windows semantics for missing files. This means throwing FileNotFound only if the last segment of the path can't be found. * Dispose handle and trim ending separator properly
stephentoub
approved these changes
May 22, 2017
ianhays
approved these changes
May 22, 2017
|
#11757 is the master fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port for issue https://github.com/dotnet/corefx/issues/20040. CoreFX part is dotnet/corefx#20134.
Need to match Windows semantics for missing files. This means throwing
FileNotFound only if the last segment of the path can't be found.