This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Update Unix SafeHandle to throw NotFound correctly #11757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to match Windows semantics for missing files. This means throwing FileNotFound only if the last segment of the path can't be found.
|
Validated fully. |
stephentoub
reviewed
May 20, 2017
| if (handle.IsInvalid) | ||
| { | ||
| Interop.ErrorInfo error = Interop.Sys.GetLastErrorInfo(); | ||
|
|
There was a problem hiding this comment.
Ideally we'd dispose of the handle, even though it's invalid, to avoid it needing to be finalized.
There was a problem hiding this comment.
Thanks- totally overlooked that.
stephentoub
approved these changes
May 20, 2017
|
Disposed the handle and ported dotnet/corefx#20049 |
ianhays
approved these changes
May 22, 2017
|
@stephentoub Can you take a look at the update? |
stephentoub
approved these changes
May 22, 2017
JeremyKuhne
added a commit
to JeremyKuhne/coreclr
that referenced
this pull request
May 22, 2017
* Update Unix SafeHandle to throw NotFound correctly Need to match Windows semantics for missing files. This means throwing FileNotFound only if the last segment of the path can't be found. * Dispose handle and trim ending separator properly
JeremyKuhne
added a commit
that referenced
this pull request
May 23, 2017
* Update Unix SafeHandle to throw NotFound correctly Need to match Windows semantics for missing files. This means throwing FileNotFound only if the last segment of the path can't be found. * Dispose handle and trim ending separator properly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to match Windows semantics for missing files. This means throwing
FileNotFound only if the last segment of the path can't be found.
Related to dotnet/corefx#19959 and https://github.com/dotnet/corefx/issues/19850.