Razor EA changes to allow better tests in Razor #74402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
davidwengier
commented
Jul 16, 2024
davidwengier
commented
- Moves things used for testing into a Testing folder so we know its safe to change
- Allows creation of the test language server with a different language server kind (for cohosting)
- Allows tests to use the RazorPinnedSolutionInfoWrapper
- Tiny bit of clean up
Also moved files needed for testing into a testing folder so we don't get them mixed up
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
davidwengier
commented
Jul 16, 2024
| [Shared] | ||
| internal class RazorLanguageServerFactoryWrapper : AbstractRazorLanguageServerFactoryWrapper | ||
| [Export(typeof(RazorTestLanguageServerFactory))] | ||
| [Export(typeof(AbstractRazorLanguageServerFactoryWrapper))] |
There was a problem hiding this comment.
The abstract class is only used for this export, and was probably just copied from Razor where we used to use abstract classes a lot. I'm exporting it as itself now, so that we can remove the abstract class in future, but we have to wait until these changes make it to VS Preview images for that to happen, or the Roslyn integration tests will fail.
JoeRobich
approved these changes
Jul 16, 2024
davidwengier
added a commit
to dotnet/razor
that referenced
this pull request
Jul 18, 2024
Part of #9519 and #10603 Requires dotnet/roslyn#74402 Removes a little more dodginess in the cohosting tests by actually using the `RazorPinnedSolutionInfoWrapper` for solution checksums, just like the real OOP services.
This was referenced Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.