Remove dodgy UpdateSolution method in cohosting tests
#10627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
commented
Jul 16, 2024
src/Razor/src/Microsoft.CodeAnalysis.Remote.Razor/ProjectSystem/ProjectSnapshotFactory.cs
Outdated
Show resolved
Hide resolved
DustinCampbell
previously requested changes
Jul 16, 2024
src/Razor/src/Microsoft.CodeAnalysis.Remote.Razor/ProjectSystem/DocumentSnapshotFactory.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.CodeAnalysis.Remote.Razor/ProjectSystem/ProjectSnapshotFactory.cs
Outdated
Show resolved
Hide resolved
davidwengier
commented
Jul 16, 2024
src/Razor/src/Microsoft.CodeAnalysis.Remote.Razor/ProjectSystem/DocumentSnapshotFactory.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.CodeAnalysis.Remote.Razor/ProjectSystem/ProjectSnapshotFactory.cs
Outdated
Show resolved
Hide resolved
davidwengier
dismissed
DustinCampbell’s stale review
Done! Thank you for the feedback
davidwengier
force-pushed
the
dev/dawengie/FixSolutionIssueWithCohostTests
branch
from
6cecd91
to
96b3fa3
Compare
|
Sorry for force pushing, but we have a real Roslyn version now. |
ryzngard
approved these changes
Jul 17, 2024
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Roslyn insertion just merged, so going to update this to the real package version and merge. Then I can finally rebase my other PRs :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #9519 and #10603
Requires dotnet/roslyn#74402
Removes a little more dodginess in the cohosting tests by actually using the
RazorPinnedSolutionInfoWrapperfor solution checksums, just like the real OOP services.