Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert ImplementTypeOptions to editorconfig options #74376

Merged
merged 5 commits into from
Jul 16, 2024
Merged

Convert ImplementTypeOptions to editorconfig options #74376

merged 5 commits into from
Jul 16, 2024

Conversation

tmat
Copy link
Member

@tmat tmat commented Jul 12, 2024 •
edited
Loading

The new option is available in editorconfig:

dotnet_member_insertion_location = with_other_members_of_the_same_kind | at_the_end

VS Code settings change from

dotnet.implementType.insertionBehavior
dotnet.implementType.propertyGenerationBehavior

to

dotnet.typeMembers.memberInsertionLocation
dotnet.typeMembers.propertyGenerationBehavior

VS Code name mapping for backward compat: dotnet/vscode-csharp#7356

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 12, 2024
@tmat tmat changed the title Implement type options Convert ImplementTypeOptions to editorconfig options Jul 12, 2024
@build-analysis build-analysis bot mentioned this pull request Jul 13, 2024
Open
3 tasks
@tmat tmat mentioned this pull request Jul 15, 2024
Merged
@tmat tmat marked this pull request as ready for review July 15, 2024 19:04
@tmat tmat requested a review from a team as a code owner July 15, 2024 19:04
@tmat tmat mentioned this pull request Jul 16, 2024
Merged
@tmat tmat enabled auto-merge (squash) July 16, 2024 19:41
@build-analysis build-analysis bot mentioned this pull request Jul 16, 2024
Open
3 tasks
@tmat tmat merged commit fa643d6 into dotnet:main Jul 16, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jul 16, 2024
@tmat tmat deleted the ImplementTypeOptions branch July 16, 2024 20:48
This was referenced Jul 19, 2024
Closed
Closed
@RikkiGibson RikkiGibson modified the milestones: Next, 17.12 P1 Jul 29, 2024
@dotnet-bot dotnet-bot mentioned this pull request Aug 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.12 P1
Development

Successfully merging this pull request may close these issues.
3 participants
@tmat @CyrusNajmabadi @RikkiGibson