Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert HideAdvancedMembers option to editorconfig option #74360

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

tmat
Copy link
Member

@tmat tmat commented Jul 11, 2024

Change the editorconfig name of the option from dotnet_hide_advanced_members_in_completion to dotnet_hide_advanced_members.

Add new section ".NET Code Actions" to editorconfig, so that the option is serialized into editorconfig like so:

#### .NET Code Actions ####

# Type members
dotnet_hide_advanced_members = true|false

A follow-up PR (#74376) we will add a couple of more options to this group:

dotnet_member_insertion_location = with_other_members_of_the_same_kind | at_the_end
dotnet_property_generation_behavior =  prefer_throwing_properties | prefer_auto_properties

Move HideAdvancedMembers option to a new MemberDisplayOptions struct and add extension methods to retrieve it from document.
Replace SignatureHelpOptions with MemberDisplayOptions as it only contains HideAdvancedMembers.
Add GetAddImportOptionsAsync extension method to follow the established pattern.
Remove AddMissingImportsOptions.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 11, 2024
@tmat tmat changed the title Member display options Convert HideAdvancedMembers option to editorconfig option Jul 11, 2024
@tmat tmat marked this pull request as ready for review July 12, 2024 18:37
@tmat tmat requested a review from a team as a code owner July 12, 2024 18:37
@tmat
Copy link
Member Author

tmat commented Jul 15, 2024

@dotnet/roslyn-ide @sharwell @Cosifne @CyrusNajmabadi ptal

@tmat tmat merged commit 93e2561 into dotnet:main Jul 15, 2024
25 checks passed
@tmat tmat deleted the MemberDisplayOptions branch July 15, 2024 17:03
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jul 15, 2024
@RikkiGibson RikkiGibson modified the milestones: Next, 17.12 P1 Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants