Clarify error for AssemblyVersion with wildcard when deterministic VB

src/Compilers/VisualBasic/Portable/Errors/ErrorFacts.vb

@@ -20,7 +20,7 @@ Namespace Microsoft.CodeAnalysis.VisualBasic
                      ERRID.ERR_MissingRuntimeHelper,
                      ERRID.ERR_CannotGotoNonScopeBlocksWithClosure,
                      ERRID.ERR_SymbolDefinedInAssembly
-                    ' Update src\EditorFeatures\VisualBasic\LanguageServer\VisualBasicLspBuildOnlyDiagnostics.vb
+                    ' Update src\Features\VisualBasic\Portable\Diagnostics\LanguageServer\VisualBasicLspBuildOnlyDiagnostics.vb
                     ' whenever new values are added here.
                     Return True
                 Case ERRID.Void,
@@ -1215,6 +1215,7 @@ Namespace Microsoft.CodeAnalysis.VisualBasic
                      ERRID.ERR_FailureSigningAssembly,
                      ERRID.ERR_SignButNoPrivateKey,
                      ERRID.ERR_InvalidVersionFormat,
+                     ERRID.ERR_InvalidVersionFormatDeterministic,
                      ERRID.ERR_ExpectedSingleScript,
                      ERRID.ERR_ReferenceDirectiveOnlyAllowedInScripts,
                      ERRID.ERR_NamespaceNotAllowedInScript,

src/Compilers/VisualBasic/Portable/Errors/Errors.vb

@@ -72,6 +72,8 @@ Namespace Microsoft.CodeAnalysis.VisualBasic
         ERR_MutuallyExclusiveOptions = 2046
         ERR_BadSwitchValue = 2047
 
+        ERR_InvalidVersionFormatDeterministic = 8357
+
         '// The naming convention is that if your error requires arguments, to append
         '// the number of args taken, e.g. AmbiguousName2
         '//

src/Compilers/VisualBasic/Portable/Symbols/Source/SourceAssemblySymbol.vb

@@ -1042,8 +1042,14 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.Symbols
                 Dim verString = DirectCast(attrData.CommonConstructorArguments(0).ValueInternal, String)
                 Dim version As Version = Nothing
                 If Not VersionHelper.TryParseAssemblyVersion(verString, allowWildcard:=Not _compilation.IsEmitDeterministic, version:=version) Then
-                    diagnostics.Add(ERRID.ERR_InvalidVersionFormat, GetAssemblyAttributeFirstArgumentLocation(arguments.AttributeSyntaxOpt))
+                    Dim attributeArgumentSyntaxLocation As Location = GetAssemblyAttributeFirstArgumentLocation(arguments.AttributeSyntaxOpt)
+                    If _compilation.IsEmitDeterministic AndAlso verString?.Contains("*"c) = True Then
+                        diagnostics.Add(ERRID.ERR_InvalidVersionFormatDeterministic, attributeArgumentSyntaxLocation)
+                    Else
+                        diagnostics.Add(ERRID.ERR_InvalidVersionFormat, attributeArgumentSyntaxLocation)
+                    End If
                 End If
+
                 arguments.GetOrCreateData(Of CommonAssemblyWellKnownAttributeData)().AssemblyVersionAttributeSetting = version
             ElseIf attrData.IsTargetAttribute(AttributeDescription.AssemblyFileVersionAttribute) Then
                 Dim dummy As Version = Nothing

src/Compilers/VisualBasic/Portable/VBResources.resx

@@ -4386,7 +4386,7 @@
     <value>The specified version string does not conform to the recommended format</value>
   </data>
   <data name="ERR_InvalidVersionFormat2" xml:space="preserve">
-    <value>The specified version string does not conform to the recommended format - major.minor.build.revision</value>
+    <value>The specified version string does not conform to the recommended format - major.minor.build.revision (without wildcards)</value>
   </data>
   <data name="ERR_InvalidAssemblyCultureForExe" xml:space="preserve">
     <value>Executables cannot be satellite assemblies; culture should always be empty</value>
@@ -5704,4 +5704,7 @@
   <data name="WRN_ConvertingLock_Title" xml:space="preserve">
     <value>A value of type 'System.Threading.Lock' converted to a different type will use likely unintended monitor-based locking in SyncLock statement.</value>
   </data>
-</root>
+  <data name="ERR_InvalidVersionFormatDeterministic" xml:space="preserve">
+    <value>The specified version string contains wildcards, which are not compatible with determinism. Either remove wildcards from the version string, or disable determinism for this compilation</value>
+  </data>
+</root>