Clarify error for AssemblyVersion with wildcard when deterministic VB #74351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Translate solution from CSharp to VB from PR dotnet#22973 - Fix path to VisualBasicLspBuildOnlyDiagnostics in comment
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
dotnet-policy-service
bot
added
the
Community
|
@dotnet-policy-service agree |
jaredpar
reviewed
Jul 11, 2024
src/Compilers/VisualBasic/Portable/Symbols/Source/SourceAssemblySymbol.vb
Outdated
Show resolved
Hide resolved
Leave them as is. Our translation team updates these regularly. |
To match the most recent CSharp branch
jaredpar
reviewed
Jul 11, 2024
333fred
approved these changes
Jul 11, 2024
jaredpar
approved these changes
Jul 11, 2024
|
Thanks @A9G-Data-Droid ! |
This was referenced Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translate CSharp solution to VB from PR #22973
KNOWN ISSUE:
This has generated a series of
needs-review-translationflags in other language files. Should I make an attempt at updating languages I do not speak? Or leave this to go through a translation process?