Allow contextual modifiers in any order in type declarations #42097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LMK when you woudl like a review. |
By moving most of the logic about back compat into the section for parsing ref structs specifically, it makes it simpler to use one helper in the future
|
Possible related issue: #22439 |
jcouv
added
the
PR For Personal Review Only
|
@jcouv What is the state for this change? I think it would be a nice addition beside non-void partials. |
|
I'm not sure about the status. @agocke Is this a PR you plan to push forward despite your role change? |
|
@jcouv Nope, turns out it wasn't necessary for records. Anyone else is free to pick it up though -- I still think it's a good change. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.