Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

partial check is in the parser because of initial problems moving it to binding #22439

Closed
agocke opened this issue Sep 29, 2017 · 0 comments · Fixed by #62686
Closed

partial check is in the parser because of initial problems moving it to binding #22439

agocke opened this issue Sep 29, 2017 · 0 comments · Fixed by #62686
Labels
Area-Compilers Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality
Milestone
Backlog

Comments

@agocke
Copy link
Member

agocke commented Sep 29, 2017 •
edited
Loading

In #22403 the checks in bindingfor the location of the partial keyword cause us to tug on the SyntaxReference. We should consider putting the check back in binding, but in the declaration table to avoid keeping syntax trees alive.
@agocke agocke added this to the 15.later milestone Sep 29, 2017
@agocke agocke changed the title Moving partial check to binding types causes multiple parses partial check is in the parser because of initial problems moving it to binding Sep 29, 2017
@jcouv jcouv modified the milestones: 15.6, 15.7 Oct 31, 2017
@jaredpar jaredpar modified the milestones: 15.7, 16.0 Jan 8, 2018
@jaredpar jaredpar modified the milestones: 16.0, Unknown Sep 4, 2018
@gafter gafter added the Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality label Oct 24, 2019
@alrz alrz mentioned this issue Mar 6, 2020
Closed
@Youssef1313 Youssef1313 mentioned this issue Jul 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Compilers Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Produce errors for 'partial file record' Youssef1313/roslyn
4 participants
@jaredpar @agocke @gafter @jcouv