Require JoinableTaskContext be provided in the MEF container for EditorFeatures #29309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharwell
commented
Aug 15, 2018
| using Roslyn.Utilities; | ||
|
|
||
| namespace Microsoft.CodeAnalysis.Editor.Shared.Utilities | ||
| namespace Microsoft.CodeAnalysis.Test.Utilities |
There was a problem hiding this comment.
📝 Note that this whole class moved from production code to test code.
sharwell
force-pushed
the
require-vs-threading
branch
from
05ea602 to
53631bd
Compare
|
@sharwell can you update this |
…orFeatures This requirement was inherited from other dependencies, and does not introduce new requirements for downstream components. The dependency requirement is leveraged to simplify code on production code paths. Fixes dotnet#29278 Closes dotnet#29279
sharwell
force-pushed
the
require-vs-threading
branch
from
53631bd to
79009ac
Compare
|
@jinujoseph done |
xoofx
pushed a commit
to stark-lang/stark-roslyn
that referenced
this pull request
Apr 16, 2019
Require JoinableTaskContext be provided in the MEF container for EditorFeatures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requirement was inherited from other dependencies, and does not introduce new requirements for downstream components. The dependency requirement is leveraged to simplify code on production code paths.
Fixes #29278
Closes #29279