Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider making JoinableTaskContext a required import #29279

Closed
sharwell opened this issue Aug 14, 2018 · 0 comments
Closed

Consider making JoinableTaskContext a required import #29279

sharwell opened this issue Aug 14, 2018 · 0 comments
Assignees
@sharwell
Labels
Area-IDE Concept-Continuous Improvement Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Milestone
16.0.P3

Comments

@sharwell
Copy link
Member

From #28781 (comment):

Consider making JoinableTaskContext a required import for ThreadingContext
@sharwell sharwell mentioned this issue Aug 15, 2018
Merged
@sharwell sharwell self-assigned this Aug 15, 2018
@sharwell sharwell added 4 - In Review A fix for the issue is submitted for review. Concept-Continuous Improvement labels Aug 15, 2018
@sharwell sharwell added this to the 16.0 milestone Aug 15, 2018
@jinujoseph jinujoseph modified the milestones: 16.0, 16.0.P3 Jan 18, 2019
sharwell added a commit to sharwell/roslyn that referenced this issue Jan 18, 2019
@sharwell
Require JoinableTaskContext be provided in the MEF container for Edit…
79009ac 
…orFeatures

This requirement was inherited from other dependencies, and does not introduce new
requirements for downstream components. The dependency requirement is leveraged to
simplify code on production code paths.

Fixes dotnet#29278
Closes dotnet#29279
@sharwell sharwell added Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented and removed 4 - In Review A fix for the issue is submitted for review. labels Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharwell sharwell

Labels
Area-IDE Concept-Continuous Improvement Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Projects
None yet
Milestone
16.0.P3
Development

No branches or pull requests
3 participants
@jaredpar @sharwell @jinujoseph