Closure struct should not be abstract #13194
Conversation
gafter
added
Area-Compilers
New Language Feature - Local Functions
| @@ -149,7 +149,7 @@ public override bool IsSealed | |||
|
|
|||
| public override bool IsAbstract | |||
There was a problem hiding this comment.
Wanna just make this an expression-bodied property?
There was a problem hiding this comment.
There are many single-line properties and methods in this file, including directly above and below this property. Should I change those too?
There was a problem hiding this comment.
@svick I'm fine with that, but you don't have to.
There was a problem hiding this comment.
@agocke Done, for the whole file.
|
retest microbuild_prtest please |
|
LGTM |
|
/cc @dotnet/roslyn-compiler For another review. I said he could also simplify the code with expression bodied members. If you'd prefer to review the change without the formatting simplification, just look at the first commit. |
|
LGTM |
|
@svick Thanks for the contribution, it's much appreciated! |
Fixes #13191.
This confuses tools like Reflector and custom tools that don't expect
structs to be markedabstract.It does not seem to be an issue for CLR or peverify (maybe it should?).