C#7 local function generated structures shouldn't be declared as static

[ndepend]

Version Used: dev15 preview 3

Steps to Reproduce: I compile code from this blog post.

private static void Main(string[] args)
{
    int localVar = 42;
    int LocalFunction(int arg)
    {
        return localVar * arg;
    }
    Console.WriteLine(LocalFunction(1));
}

Actual Behavior: The structure generated under the wood by the compiler to handle localVar is declared as static (and the field localVar is a non-static field)

Expected Behavior: Such generated structure shouldn't be declared as static.

As the developer of a static analyzer that churns IL code this matters. Unless there is a real technical reason for declaring such structure as static, it'd be cleaner to not do so.

---

Note: Reflector see the structure as a static class that derives from value type (it is a Reflector bug that it doesn't tell it is a structure).

Our static analyzer that relies on Cecil for IL read, shows that the generated structure is both abstract and sealed (which means static).

[svick]

As far as I can tell, the tools are confused, because the type is marked as abstract. Somehow, CLR (and peverify) doesn't mind and treats it as a normal struct.

I think this is a bug, so I have submitted a PR to fix it.

[gafter]

@agocke a community member has submitted a PR to fix this.

[ndepend]

FYI I tested with VS2017 RC and the bug is indeed fixed, thanks