Revert change to IIncrementalAnalyzer interface #12074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @dotnet/roslyn-interactive |
| <Name>Features</Name> | ||
| <ReferenceOutputAssembly>false</ReferenceOutputAssembly> |
There was a problem hiding this comment.
It feels odd that we're reverting this. Was it part of the original change?
There was a problem hiding this comment.
It looks like it was a part of the original commit 1b6a83f although I'm not sure why VS updated this file since I did not modify this file manually
There was a problem hiding this comment.
Actually, I looked at the rest of this project, and we do this for many of the other references. My guess is we shouldn't have deleted this in the first place. We should just make sure we don't delete it again in features-testimpact.
|
LGTM (except |
This was referenced Jun 17, 2016
KevinH-MS
added a commit
that referenced
this pull request
Jun 21, 2016
Revert "Merge pull request #12074 from drognanar/revertreasons"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts PR #11275