Roslyn crashes on VS2015 Update3 RC

[bkoelman]

Version Used:
VS2015 Update3 RC, master branch at 5416d9c.

Steps to Reproduce:

1. Follow steps at Building, Debugging, and Testing on Windows, set VisualStudioSetup as startup project, F5
2. In second VS instance, create new C# Console Application
3. First instance with debugger attached breaks with exception in IncrementalAnalyzerProcessor:

An exception of type 'System.TypeLoadException' occurred in Microsoft.CodeAnalysis.Features.dll but was not handled in user code

Additional information: Method 'AnalyzeSyntaxAsync' in type 'Analyzer' from assembly 'Microsoft.VisualStudio.LanguageServices.Telemetry, Version=1.3.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' does not have an implementation.

1. Detach debugger; second VS instance crashes.

Expected Behavior:
Project gets created and loaded successfully.

Actual Behavior:
VS crashes.

[bkoelman]

During build, VS shows the next warnings in Error list that might be related:

Severity    Code    Description Project File    Line    Suppression State
Warning     Unable to add a reference to project 'BasicScripting'. The targets of Portable Library project 'BasicScripting' are not the same or compatible with the targets of the current Portable Library project.

A Portable Library project's targets can be changed via the Library tab in the project's properties.    ScriptingTest           
Warning     Unable to add a reference to project 'BasicScripting'. The targets of Portable Library project 'BasicScripting' are not the same or compatible with the targets of the current Portable Library project.

A Portable Library project's targets can be changed via the Library tab in the project's properties.    BasicScriptingTest          
Warning     Unable to add a reference to project 'BasicScripting'. The targets of Portable Library project 'BasicScripting' are not the same or compatible with the targets of the current Portable Library project.

A Portable Library project's targets can be changed via the Library tab in the project's properties.    VbiCore         
Warning     Unable to add a reference to project 'CommonCoreClrRuntime'. The targets of Portable Library project 'CommonCoreClrRuntime' are not the same or compatible with the targets of the current Portable Library project.

A Portable Library project's targets can be changed via the Library tab in the project's properties.    DeployCompilerGeneratorToolsRuntime         
Warning     Unable to add a reference to project 'CommonNetCoreReferences'. The targets of Portable Library project 'CommonNetCoreReferences' are not the same or compatible with the targets of the current Portable Library project.

A Portable Library project's targets can be changed via the Library tab in the project's properties.    CscCore         
Warning     Unable to add a reference to project 'CommonNetCoreReferences'. The targets of Portable Library project 'CommonNetCoreReferences' are not the same or compatible with the targets of the current Portable Library project.

A Portable Library project's targets can be changed via the Library tab in the project's properties.    CsiCore         
Warning     Unable to add a reference to project 'CommonNetCoreReferences'. The targets of Portable Library project 'CommonNetCoreReferences' are not the same or compatible with the targets of the current Portable Library project.

A Portable Library project's targets can be changed via the Library tab in the project's properties.    DeployCoreClrTestRuntime            
Warning     Unable to add a reference to project 'CommonNetCoreReferences'. The targets of Portable Library project 'CommonNetCoreReferences' are not the same or compatible with the targets of the current Portable Library project.

A Portable Library project's targets can be changed via the Library tab in the project's properties.    PortableServer          
Warning     Unable to add a reference to project 'CommonNetCoreReferences'. The targets of Portable Library project 'CommonNetCoreReferences' are not the same or compatible with the targets of the current Portable Library project.

A Portable Library project's targets can be changed via the Library tab in the project's properties.    VbcCore         
Warning     Unable to add a reference to project 'CommonNetCoreReferences'. The targets of Portable Library project 'CommonNetCoreReferences' are not the same or compatible with the targets of the current Portable Library project.

A Portable Library project's targets can be changed via the Library tab in the project's properties.    VbiCore         
Warning     Unable to add a reference to project 'CompilersBoundTreeGenerator'. The targets of Portable Library project 'CompilersBoundTreeGenerator' are not the same or compatible with the targets of the current Portable Library project.

A Portable Library project's targets can be changed via the Library tab in the project's properties.    DeployCompilerGeneratorToolsRuntime         
Warning     Unable to add a reference to project 'CSharpCompilerSyntaxTest'. The targets of Portable Library project 'CSharpCompilerSyntaxTest' are not the same or compatible with the targets of the current Portable Library project.

A Portable Library project's targets can be changed via the Library tab in the project's properties.    DeployCoreClrTestRuntime            
Warning     Unable to add a reference to project 'CSharpCompilerTestUtilities'. The targets of Portable Library project 'CSharpCompilerTestUtilities' are not the same or compatible with the targets of the current Portable Library project.

A Portable Library project's targets can be changed via the Library tab in the project's properties.    CSharpCompilerSyntaxTest            
Warning     Unable to add a reference to project 'CSharpErrorFactsGenerator'. The targets of Portable Library project 'CSharpErrorFactsGenerator' are not the same or compatible with the targets of the current Portable Library project.

A Portable Library project's targets can be changed via the Library tab in the project's properties.    DeployCompilerGeneratorToolsRuntime         
Warning     Unable to add a reference to project 'CSharpScripting'. The targets of Portable Library project 'CSharpScripting' are not the same or compatible with the targets of the current Portable Library project.

A Portable Library project's targets can be changed via the Library tab in the project's properties.    ScriptingTest           
Warning     Unable to add a reference to project 'CSharpScripting'. The targets of Portable Library project 'CSharpScripting' are not the same or compatible with the targets of the current Portable Library project.

A Portable Library project's targets can be changed via the Library tab in the project's properties.    CSharpScriptingTest         
Warning     Unable to add a reference to project 'CSharpScripting'. The targets of Portable Library project 'CSharpScripting' are not the same or compatible with the targets of the current Portable Library project.

A Portable Library project's targets can be changed via the Library tab in the project's properties.    CsiCore         
Warning     Unable to add a reference to project 'CSharpSyntaxGenerator'. The targets of Portable Library project 'CSharpSyntaxGenerator' are not the same or compatible with the targets of the current Portable Library project.

A Portable Library project's targets can be changed via the Library tab in the project's properties.    DeployCompilerGeneratorToolsRuntime         
Warning     Unable to add a reference to project 'Scripting'. The targets of Portable Library project 'Scripting' are not the same or compatible with the targets of the current Portable Library project.

A Portable Library project's targets can be changed via the Library tab in the project's properties.    BasicScripting          
Warning     Unable to add a reference to project 'Scripting'. The targets of Portable Library project 'Scripting' are not the same or compatible with the targets of the current Portable Library project.

A Portable Library project's targets can be changed via the Library tab in the project's properties.    CSharpScripting         
Warning     Unable to add a reference to project 'Scripting'. The targets of Portable Library project 'Scripting' are not the same or compatible with the targets of the current Portable Library project.

A Portable Library project's targets can be changed via the Library tab in the project's properties.    ScriptingTest           
Warning     Unable to add a reference to project 'Scripting'. The targets of Portable Library project 'Scripting' are not the same or compatible with the targets of the current Portable Library project.

A Portable Library project's targets can be changed via the Library tab in the project's properties.    BasicScriptingTest          
Warning     Unable to add a reference to project 'Scripting'. The targets of Portable Library project 'Scripting' are not the same or compatible with the targets of the current Portable Library project.

A Portable Library project's targets can be changed via the Library tab in the project's properties.    CSharpScriptingTest         
Warning     Unable to add a reference to project 'Scripting'. The targets of Portable Library project 'Scripting' are not the same or compatible with the targets of the current Portable Library project.

A Portable Library project's targets can be changed via the Library tab in the project's properties.    CsiCore         
Warning     Unable to add a reference to project 'Scripting'. The targets of Portable Library project 'Scripting' are not the same or compatible with the targets of the current Portable Library project.

A Portable Library project's targets can be changed via the Library tab in the project's properties.    VbiCore         
Warning     Unable to add a reference to project 'ScriptingTest'. The targets of Portable Library project 'ScriptingTest' are not the same or compatible with the targets of the current Portable Library project.

A Portable Library project's targets can be changed via the Library tab in the project's properties.    BasicScriptingTest          
Warning     Unable to add a reference to project 'ScriptingTest'. The targets of Portable Library project 'ScriptingTest' are not the same or compatible with the targets of the current Portable Library project.

A Portable Library project's targets can be changed via the Library tab in the project's properties.    CSharpScriptingTest         
Warning     Unable to add a reference to project 'ScriptingTest'. The targets of Portable Library project 'ScriptingTest' are not the same or compatible with the targets of the current Portable Library project.

A Portable Library project's targets can be changed via the Library tab in the project's properties.    DeployCoreClrTestRuntime            
Warning     Unable to add a reference to project 'TestUtilities'. The targets of Portable Library project 'TestUtilities' are not the same or compatible with the targets of the current Portable Library project.

A Portable Library project's targets can be changed via the Library tab in the project's properties.    CSharpCompilerTestUtilities         
Warning     Unable to add a reference to project 'TestUtilities'. The targets of Portable Library project 'TestUtilities' are not the same or compatible with the targets of the current Portable Library project.

A Portable Library project's targets can be changed via the Library tab in the project's properties.    ScriptingTest           
Warning     Unable to add a reference to project 'TestUtilities'. The targets of Portable Library project 'TestUtilities' are not the same or compatible with the targets of the current Portable Library project.

A Portable Library project's targets can be changed via the Library tab in the project's properties.    BasicScriptingTest          
Warning     Unable to add a reference to project 'TestUtilities'. The targets of Portable Library project 'TestUtilities' are not the same or compatible with the targets of the current Portable Library project.

A Portable Library project's targets can be changed via the Library tab in the project's properties.    CSharpCompilerSyntaxTest            
Warning     Unable to add a reference to project 'TestUtilities'. The targets of Portable Library project 'TestUtilities' are not the same or compatible with the targets of the current Portable Library project.

A Portable Library project's targets can be changed via the Library tab in the project's properties.    CSharpScriptingTest         
Warning     Unable to add a reference to project 'VisualBasicErrorFactsGenerator'. The targets of Portable Library project 'VisualBasicErrorFactsGenerator' are not the same or compatible with the targets of the current Portable Library project.

A Portable Library project's targets can be changed via the Library tab in the project's properties.    DeployCompilerGeneratorToolsRuntime         
Warning     Unable to add a reference to project 'VisualBasicSyntaxGenerator'. The targets of Portable Library project 'VisualBasicSyntaxGenerator' are not the same or compatible with the targets of the current Portable Library project.

A Portable Library project's targets can be changed via the Library tab in the project's properties.    DeployCompilerGeneratorToolsRuntime         

[Pilchie]

Tag @heejaechang

[heejaechang]

tag @KevinH-MS

basically, it looks like we are saying we should consider all internal API we use in closed side as public API.

[jmarolf]

We consider them "public" if they break the public development experience, yes.

[heejaechang]

Unless we provide them a way to patch those side as well…

•      heejae
  

From: Jonathon Marolf [mailto:notifications@github.com]
Sent: Friday, June 17, 2016 1:48 PM
To: dotnet/roslyn roslyn@noreply.github.com
Cc: HeeJae Chang Heejae.Chang@microsoft.com; Mention mention@noreply.github.com
Subject: Re: [dotnet/roslyn] Roslyn crashes on VS2015 Update3 RC (#12066)

We consider them "public" if they break the public development experience, yes.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//issues/12066#issuecomment-226877689, or mute the threadhttps://github.com/notifications/unsubscribe/ABRXu4tplVDDKjb9Y5_TdCjd0EZSEgx9ks5qMwgVgaJpZM4I37ch.

[jmarolf]

@heejaechang I don't particularly care about how we go about it, as long as when someone presses F5 everything works.

[heejaechang]

Yay, I agree we should make people be able to run vs using their own bit, but I just hoped that doesn’t involve making cross cutting changes harder than now.

•      heejae
  

From: Jonathon Marolf [mailto:notifications@github.com]
Sent: Friday, June 17, 2016 2:27 PM
To: dotnet/roslyn roslyn@noreply.github.com
Cc: HeeJae Chang Heejae.Chang@microsoft.com; Mention mention@noreply.github.com
Subject: Re: [dotnet/roslyn] Roslyn crashes on VS2015 Update3 RC (#12066)

@heejaechanghttps://github.com/heejaechang I don't particularly care about how we go about it, as long as when someone presses F5 everything works.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//issues/12066#issuecomment-226885563, or mute the threadhttps://github.com/notifications/unsubscribe/ABRXu1JAZ5jgiHhcu98Uw-8s5GQSyzpnks5qMxEsgaJpZM4I37ch.

[KevinH-MS]

Fixed with #12074. Thanks for reporting and sorry about that!

[bkoelman]

This was only the first in a series of errors. The next one is at https://github.com/dotnet/roslyn/blob/master/src/VisualStudio/CSharp/Impl/Options/AutomationObject.cs#L660:

An exception of type 'System.TypeLoadException' occurred in mscorlib.dll but was not handled in user code

Additional information: Method 'AnalyzeSyntaxAsync' in type 'Analyzer' from assembly 'Microsoft.VisualStudio.LanguageServices.Telemetry, Version=1.3.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' does not have an implementation.

And then later followed by: