Skip to content

Commit

Permalink
Revert "Respond to breaking changes to CLaSP"
Browse files Browse the repository at this point in the history
This reverts commit 971268d.
  • Loading branch information
davidwengier committed Jan 21, 2024
1 parent c3268c5 commit 699c3f2
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public static void AddLifeCycleServices(this IServiceCollection services, RazorL
services.AddSingleton<RazorLifeCycleManager>(razorLifeCycleManager);
services.AddSingleton<CapabilitiesManager>();
services.AddSingleton<IInitializeManager<InitializeParams, InitializeResult>, CapabilitiesManager>(sp => sp.GetRequiredService<CapabilitiesManager>());
services.AddSingleton<AbstractRequestContextFactory<RazorRequestContext>, RazorRequestContextFactory>();
services.AddSingleton<IRequestContextFactory<RazorRequestContext>, RazorRequestContextFactory>();

services.AddSingleton<ICapabilitiesProvider, RazorLanguageServerCapability>();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ internal partial class RazorLanguageServer : AbstractLanguageServer<RazorRequest
private readonly ClientConnection _clientConnection;

// Cached for testing
private AbstractHandlerProvider? _handlerProvider;
private IHandlerProvider? _handlerProvider;

public RazorLanguageServer(
JsonRpc jsonRpc,
Expand Down Expand Up @@ -80,7 +80,7 @@ private static ILspLogger CreateILspLogger(IRazorLoggerFactory loggerFactory, IT

protected override IRequestExecutionQueue<RazorRequestContext> ConstructRequestExecutionQueue()
{
var handlerProvider = this.HandlerProvider;
var handlerProvider = GetHandlerProvider();
var queue = new RazorRequestExecutionQueue(this, _logger, handlerProvider);
queue.Start();
return queue;
Expand Down Expand Up @@ -199,14 +199,11 @@ static void AddHandlers(IServiceCollection services, LanguageServerFeatureOption
}
}

protected override AbstractHandlerProvider HandlerProvider
protected override IHandlerProvider GetHandlerProvider()
{
get
{
_handlerProvider ??= base.HandlerProvider;
_handlerProvider ??= base.GetHandlerProvider();

return _handlerProvider;
}
return _handlerProvider;
}

internal T GetRequiredService<T>() where T : notnull
Expand All @@ -231,7 +228,10 @@ public TestAccessor(RazorLanguageServer server)
_server = server;
}

public AbstractHandlerProvider HandlerProvider => _server.HandlerProvider;
public IHandlerProvider GetHandlerProvider()
{
return _server.GetHandlerProvider();
}

public RazorRequestExecutionQueue GetRequestExecutionQueue()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,16 @@

namespace Microsoft.AspNetCore.Razor.LanguageServer;

internal class RazorRequestContextFactory(ILspServices lspServices) : AbstractRequestContextFactory<RazorRequestContext>
internal class RazorRequestContextFactory(ILspServices lspServices) : IRequestContextFactory<RazorRequestContext>
{
private readonly ILspServices _lspServices = lspServices;

public override Task<RazorRequestContext> CreateRequestContextAsync<TRequestParams>(IQueueItem<RazorRequestContext> queueItem, IMethodHandler methodHandler, TRequestParams @params, CancellationToken cancellationToken)
public Task<RazorRequestContext> CreateRequestContextAsync<TRequestParams>(IQueueItem<RazorRequestContext> queueItem, TRequestParams @params, CancellationToken cancellationToken)
{
var logger = _lspServices.GetRequiredService<IRazorLoggerFactory>().CreateLogger<RazorRequestContextFactory>();

VersionedDocumentContext? documentContext = null;
var textDocumentHandler = methodHandler as ITextDocumentIdentifierHandler;
var textDocumentHandler = queueItem.MethodHandler as ITextDocumentIdentifierHandler;

Uri? uri = null;
var documentContextFactory = _lspServices.GetRequiredService<IDocumentContextFactory>();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ internal class RazorRequestExecutionQueue : RequestExecutionQueue<RazorRequestCo
private CultureInfo? _cultureInfo;
private readonly CapabilitiesManager _capabilitiesManager;

public RazorRequestExecutionQueue(AbstractLanguageServer<RazorRequestContext> languageServer, ILspLogger logger, AbstractHandlerProvider handlerProvider)
public RazorRequestExecutionQueue(AbstractLanguageServer<RazorRequestContext> languageServer, ILspLogger logger, IHandlerProvider handlerProvider)
: base(languageServer, logger, handlerProvider)
{
_capabilitiesManager = languageServer.GetLspServices().GetRequiredService<CapabilitiesManager>();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
using Microsoft.AspNetCore.Razor.ProjectSystem;
using Microsoft.AspNetCore.Razor.Test.Common.LanguageServer;
using Microsoft.AspNetCore.Razor.Test.Common.Mef;
using Microsoft.CodeAnalysis.CSharp;
using Microsoft.CodeAnalysis.Razor.ProjectSystem;
using Microsoft.CodeAnalysis.Razor.Workspaces;
using Microsoft.CodeAnalysis.Razor.Workspaces.Extensions;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public void AllHandlersRegisteredAsync()
using var server = RazorLanguageServerWrapper.Create(serverStream, serverStream, LoggerFactory, NoOpTelemetryReporter.Instance);

var innerServer = server.GetInnerLanguageServerForTesting();
var handlerProvider = innerServer.GetTestAccessor().HandlerProvider;
var handlerProvider = innerServer.GetTestAccessor().GetHandlerProvider();

var registeredMethods = handlerProvider.GetRegisteredMethods();
var handlerTypes = typeof(RazorLanguageServerWrapper).Assembly.GetTypes()
Expand Down

0 comments on commit 699c3f2

Please sign in to comment.