Respond to breaking changes to CLaSP

dotnet · Jan 19, 2024 · 971268d · 971268d
1 parent 99c35f2
commit 971268d
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 16 deletions.
diff --git a/.../src/Microsoft.AspNetCore.Razor.LanguageServer/Extensions/IServiceCollectionExtensions.cs b/.../src/Microsoft.AspNetCore.Razor.LanguageServer/Extensions/IServiceCollectionExtensions.cs
@@ -43,7 +43,7 @@ public static void AddLifeCycleServices(this IServiceCollection services, RazorL
         services.AddSingleton<RazorLifeCycleManager>(razorLifeCycleManager);
         services.AddSingleton<CapabilitiesManager>();
         services.AddSingleton<IInitializeManager<InitializeParams, InitializeResult>, CapabilitiesManager>(sp => sp.GetRequiredService<CapabilitiesManager>());
-        services.AddSingleton<IRequestContextFactory<RazorRequestContext>, RazorRequestContextFactory>();
+        services.AddSingleton<AbstractRequestContextFactory<RazorRequestContext>, RazorRequestContextFactory>();
 
         services.AddSingleton<ICapabilitiesProvider, RazorLanguageServerCapability>();
 

diff --git a/src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/RazorLanguageServer.cs b/src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/RazorLanguageServer.cs
@@ -46,7 +46,7 @@ internal partial class RazorLanguageServer : AbstractLanguageServer<RazorRequest
     private readonly ClientConnection _clientConnection;
 
     // Cached for testing
-    private IHandlerProvider? _handlerProvider;
+    private AbstractHandlerProvider? _handlerProvider;
 
     public RazorLanguageServer(
         JsonRpc jsonRpc,
@@ -80,7 +80,7 @@ private static ILspLogger CreateILspLogger(IRazorLoggerFactory loggerFactory, IT
 
     protected override IRequestExecutionQueue<RazorRequestContext> ConstructRequestExecutionQueue()
     {
-        var handlerProvider = GetHandlerProvider();
+        var handlerProvider = this.HandlerProvider;
         var queue = new RazorRequestExecutionQueue(this, _logger, handlerProvider);
         queue.Start();
         return queue;
@@ -199,11 +199,14 @@ static void AddHandlers(IServiceCollection services, LanguageServerFeatureOption
         }
     }
 
-    protected override IHandlerProvider GetHandlerProvider()
+    protected override AbstractHandlerProvider HandlerProvider
     {
-        _handlerProvider ??= base.GetHandlerProvider();
+        get
+        {
+            _handlerProvider ??= base.HandlerProvider;
 
-        return _handlerProvider;
+            return _handlerProvider;
+        }
     }
 
     internal T GetRequiredService<T>() where T : notnull
@@ -228,10 +231,7 @@ public TestAccessor(RazorLanguageServer server)
             _server = server;
         }
 
-        public IHandlerProvider GetHandlerProvider()
-        {
-            return _server.GetHandlerProvider();
-        }
+        public AbstractHandlerProvider HandlerProvider => _server.HandlerProvider;
 
         public RazorRequestExecutionQueue GetRequestExecutionQueue()
         {

diff --git a/src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/RazorRequestContextFactory.cs b/src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/RazorRequestContextFactory.cs
@@ -13,16 +13,16 @@
 
 namespace Microsoft.AspNetCore.Razor.LanguageServer;
 
-internal class RazorRequestContextFactory(ILspServices lspServices) : IRequestContextFactory<RazorRequestContext>
+internal class RazorRequestContextFactory(ILspServices lspServices) : AbstractRequestContextFactory<RazorRequestContext>
 {
     private readonly ILspServices _lspServices = lspServices;
 
-    public Task<RazorRequestContext> CreateRequestContextAsync<TRequestParams>(IQueueItem<RazorRequestContext> queueItem, TRequestParams @params, CancellationToken cancellationToken)
+    public override Task<RazorRequestContext> CreateRequestContextAsync<TRequestParams>(IQueueItem<RazorRequestContext> queueItem, IMethodHandler methodHandler, TRequestParams @params, CancellationToken cancellationToken)
     {
         var logger = _lspServices.GetRequiredService<IRazorLoggerFactory>().CreateLogger<RazorRequestContextFactory>();
 
         VersionedDocumentContext? documentContext = null;
-        var textDocumentHandler = queueItem.MethodHandler as ITextDocumentIdentifierHandler;
+        var textDocumentHandler = methodHandler as ITextDocumentIdentifierHandler;
 
         Uri? uri = null;
         var documentContextFactory = _lspServices.GetRequiredService<IDocumentContextFactory>();

diff --git a/src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/RazorRequestExecutionQueue.cs b/src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/RazorRequestExecutionQueue.cs
@@ -13,7 +13,7 @@ internal class RazorRequestExecutionQueue : RequestExecutionQueue<RazorRequestCo
     private CultureInfo? _cultureInfo;
     private readonly CapabilitiesManager _capabilitiesManager;
 
-    public RazorRequestExecutionQueue(AbstractLanguageServer<RazorRequestContext> languageServer, ILspLogger logger, IHandlerProvider handlerProvider)
+    public RazorRequestExecutionQueue(AbstractLanguageServer<RazorRequestContext> languageServer, ILspLogger logger, AbstractHandlerProvider handlerProvider)
         : base(languageServer, logger, handlerProvider)
     {
         _capabilitiesManager = languageServer.GetLspServices().GetRequiredService<CapabilitiesManager>();

diff --git a/src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Hover/HoverInfoServiceTest.cs b/src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Hover/HoverInfoServiceTest.cs
@@ -18,7 +18,6 @@
 using Microsoft.AspNetCore.Razor.ProjectSystem;
 using Microsoft.AspNetCore.Razor.Test.Common.LanguageServer;
 using Microsoft.AspNetCore.Razor.Test.Common.Mef;
-using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.Razor.ProjectSystem;
 using Microsoft.CodeAnalysis.Razor.Workspaces;
 using Microsoft.CodeAnalysis.Razor.Workspaces.Extensions;

diff --git a/src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/RazorLanguageServerTest.cs b/src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/RazorLanguageServerTest.cs
@@ -57,7 +57,7 @@ public void AllHandlersRegisteredAsync()
         using var server = RazorLanguageServerWrapper.Create(serverStream, serverStream, LoggerFactory, NoOpTelemetryReporter.Instance);
 
         var innerServer = server.GetInnerLanguageServerForTesting();
-        var handlerProvider = innerServer.GetTestAccessor().GetHandlerProvider();
+        var handlerProvider = innerServer.GetTestAccessor().HandlerProvider;
 
         var registeredMethods = handlerProvider.GetRegisteredMethods();
         var handlerTypes = typeof(RazorLanguageServerWrapper).Assembly.GetTypes()