Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move LockCheck to Utilities #10218

Merged
merged 6 commits into from
Jun 14, 2024
Merged

Move LockCheck to Utilities #10218

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fa1b7b2
move LockCheck to Utilities and make it public
JanProvaznik Jun 10, 2024
c42b2d9
move LockCheck to non-Shared utils, update resources
JanProvaznik Jun 10, 2024
cad8a80
add doc comments
JanProvaznik Jun 10, 2024
95c9d54
refactor windows condition inside LockCheck
JanProvaznik Jun 11, 2024
2992a88
use LockCheck in other Tasks which delete/modify files
JanProvaznik Jun 12, 2024
ce5deff
improve method summary
JanProvaznik Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/Tasks/Microsoft.Build.Tasks.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,6 @@
<Compile Include="LC.cs" />
<Compile Include="ListOperators\FindUnderPath.cs" />
<Compile Include="ListOperators\RemoveDuplicates.cs" />
<Compile Include="LockCheck.cs" />
<Compile Include="MakeDir.cs" />
<Compile Include="ManifestUtil\*.cs" Exclude="ManifestUtil\CngLightup.cs" />
<Compile Include="Message.cs" />
Expand Down
7 changes: 2 additions & 5 deletions src/Tasks/Resources/Strings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,11 +275,11 @@
</data>
<data name="Copy.Retrying">
<value>MSB3026: Could not copy "{0}" to "{1}". Beginning retry {2} in {3}ms. {4} {5}</value>
<comment>{StrBegin="MSB3026: "} LOCALIZATION: {0} and {1} are paths. {2} and {3} are numbers. {4} is an optional localized message. {5} is either empty or a string from Copy.FileLocked ("The file is locked by: "{0}"")</comment>
<comment>{StrBegin="MSB3026: "} LOCALIZATION: {0} and {1} are paths. {2} and {3} are numbers. {4} is an optional localized message. {5} is either empty or a string from Utilities LockCheck.FileLocked ("The file is locked by: "{0}"")</comment>
</data>
<data name="Copy.ExceededRetries">
<value>MSB3027: Could not copy "{0}" to "{1}". Exceeded retry count of {2}. Failed. {3}</value>
<comment>{StrBegin="MSB3027: "} LOCALIZATION: {0} and {1} are paths. {2} is a number. {3} is either empty or a string from Copy.FileLocked ("The file is locked by: "{0}"")</comment>
<comment>{StrBegin="MSB3027: "} LOCALIZATION: {0} and {1} are paths. {2} is a number. {3} is either empty or a string from Utilities LockCheck.FileLocked ("The file is locked by: "{0}"")</comment>
</data>
<data name="Copy.InvalidRetryCount">
<value>MSB3028: {0} is an invalid retry count. Value must not be negative.</value>
Expand All @@ -293,9 +293,6 @@
<value>MSB3030: Could not copy the file "{0}" because it was not found.</value>
<comment>{StrBegin="MSB3030: "} LOCALIZATION: {0} is a number.</comment>
</data>
<data name="Task.FileLocked">
<value>The file is locked by: "{0}"</value>
</data>

<!--
The CreateItem message bucket is: MSB3031 - MSB3040
Expand Down
13 changes: 4 additions & 9 deletions src/Tasks/Resources/xlf/Strings.cs.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 4 additions & 9 deletions src/Tasks/Resources/xlf/Strings.de.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 4 additions & 9 deletions src/Tasks/Resources/xlf/Strings.es.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 4 additions & 9 deletions src/Tasks/Resources/xlf/Strings.fr.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 4 additions & 9 deletions src/Tasks/Resources/xlf/Strings.it.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 4 additions & 9 deletions src/Tasks/Resources/xlf/Strings.ja.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading