Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move LockCheck to Utilities #10218

Conversation

JanProvaznik
Copy link
Contributor

Fixes #10001

Context

Getting message about a file being locked can be useful for non-internal task authors.

Changes Made

Moved the class, set to public, edited resources.

Testing

Notes

I moved it into non-shared Utilities folder next to Task.cs with which LockCheck is expected to be used.

Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good. We should include an example in the docs once this is public.

src/Utilities/LockCheck.cs Outdated Show resolved Hide resolved
JanProvaznik and others added 2 commits June 12, 2024 10:55
Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

@JanProvaznik JanProvaznik merged commit 8f22862 into dotnet:main Jun 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose LockCheck to task authors
4 participants