Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making MF to be a part of ML.NET #1263

Merged
merged 49 commits into from
Oct 26, 2018
Merged

Making MF to be a part of ML.NET #1263

merged 49 commits into from
Oct 26, 2018

Conversation

wschin
Copy link
Member

@wschin wschin commented Oct 15, 2018 •
edited
Loading

This PR is mainly for porting an internal MF module to ML.NET. Fixes #1262, fixes #763, fixes #1297. A notice file is added for including licenses of external packages.

@wschin wschin self-assigned this Oct 15, 2018
@wschin wschin added the enhancement New feature or request label Oct 15, 2018
singlis
singlis reviewed Oct 15, 2018
View reviewed changes
Microsoft.ML.sln Outdated Show resolved Hide resolved
eerhardt
eerhardt approved these changes Oct 24, 2018
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Ivanidzo4ka
Ivanidzo4ka approved these changes Oct 25, 2018
View reviewed changes
Copy link
Contributor

@Ivanidzo4ka Ivanidzo4ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Ivanidzo4ka
Ivanidzo4ka approved these changes Oct 25, 2018
View reviewed changes
Copy link
Contributor

@Ivanidzo4ka Ivanidzo4ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@shauheen shauheen changed the title Making MF to be a part of ML.NET [WIP] Making MF to be a part of ML.NET Oct 25, 2018
@shauheen
Copy link
Contributor

shauheen commented Oct 25, 2018 •
edited by wschin
Loading

Pending internal review #Resolved

@wschin wschin changed the title [WIP] Making MF to be a part of ML.NET Making MF to be a part of ML.NET Oct 25, 2018
@wschin wschin merged commit eae7695 into dotnet:master Oct 26, 2018
@wschin wschin deleted the portmf branch October 26, 2018 05:48
@ghost ghost locked as resolved and limited conversation to collaborators Mar 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@markusweimer markusweimer markusweimer left review comments

@shauheen shauheen shauheen left review comments

@veikkoeeva veikkoeeva veikkoeeva left review comments

@eerhardt eerhardt eerhardt approved these changes

@singlis singlis singlis left review comments

@sfilipi sfilipi sfilipi left review comments

@Zruty0 Zruty0 Zruty0 left review comments

@Ivanidzo4ka Ivanidzo4ka Ivanidzo4ka approved these changes

Assignees

@wschin wschin

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add NOTICE file Nice to have matrix factorization ML.NET packages are missing third party notices
9 participants
@wschin @shauheen @markusweimer @Ivanidzo4ka @veikkoeeva @eerhardt @singlis @sfilipi @Zruty0