Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NOTICE file #1297

Closed
markusweimer opened this issue Oct 18, 2018 · 4 comments · Fixed by #1263
Closed

Add NOTICE file #1297

markusweimer opened this issue Oct 18, 2018 · 4 comments · Fixed by #1263
Assignees

Comments

@markusweimer
Copy link
Member

We are consuming a large block of code from another project in #1263. Its license requires us to keep it available in all binary and source distributions of it. The common way to do this is to have a NOTICE file in the root of the source repo, and in the NuGets produced. We should add the NOTICE file in that way, and update it as part of #1263 if we indeed end up copying that code into our repo.

@wschin
Copy link
Member

wschin commented Oct 23, 2018

#1263 is using submodule for that source now, so I guess NOTICE is not required.

@markusweimer
Copy link
Member Author

#1263 is using submodule for that source now, so I guess NOTICE is not required.

It is still required, as it needs to be part of the NuGet

@wschin
Copy link
Member

wschin commented Oct 25, 2018

Ok. Added.

@markusweimer
Copy link
Member Author

Do we add the NOTICE to our NuGets? I did a quick check and haven't found it.

@markusweimer markusweimer reopened this Oct 29, 2018
@ghost ghost locked as resolved and limited conversation to collaborators Mar 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants