-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NOTICE file #1297
Comments
#1263 is using submodule for that source now, so I guess |
It is still required, as it needs to be part of the NuGet |
Ok. Added. |
Do we add the NOTICE to our NuGets? I did a quick check and haven't found it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We are consuming a large block of code from another project in #1263. Its license requires us to keep it available in all binary and source distributions of it. The common way to do this is to have a
NOTICE
file in the root of the source repo, and in the NuGets produced. We should add the NOTICE file in that way, and update it as part of #1263 if we indeed end up copying that code into our repo.The text was updated successfully, but these errors were encountered: