This repository has been archived by the owner on Mar 15, 2022. It is now read-only.
Annotate const loads in derefAddress #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Thanks for cleaning this up. |
Remove the exclusion for non-const loads. Annotate const loads with the !invariant.load annotation. Closes #257
|
Ignore the code formatting failure. That was a bug on my end. I've got a PR out to fix that. Make sure you've run utils\ccformat.py --untidy |
JosephTremoulet
added a commit
that referenced
this pull request
Mar 11, 2015
Annotate const loads in derefAddress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the exclusion for non-const loads.
Annotate const loads with the !invariant.load annotation.
Closes #257
Of the 10 [non-const derefAddress] rejections currently in each bring-up test, 9 change to [callRuntimeHandleHelper] and 1 succeeds.
I'll wait until #306 goes in to merge this since it depends on that.