This repository has been archived by the owner on Mar 15, 2022. It is now read-only.
Add missing case to fgSplitBlock #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle the case that a block has no terminator but does have one or more instructions after the split point. This can happen when inserting a null check during the post-processing of a newobj (which generates the call and then rewinds the insert point to do the post-processing which inserts the null check) in a block that ends with a return (and thus doesn't get a terminator in the first pass).
|
@erozenfeld PTAL |
|
LGTM |
|
The CI failures look like the ones fixed in #304, so I'm going to go ahead and merge this. |
JosephTremoulet
added a commit
that referenced
this pull request
Mar 11, 2015
Add missing case to fgSplitBlock
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle the case that a block has no terminator but does have one or more
instructions after the split point. This can happen when inserting a null
check during the post-processing of a newobj (which generates the call and
then rewinds the insert point to do the post-processing which inserts the
null check) in a block that ends with a return (and thus doesn't get a
terminator in the first pass).
Verified no IR diffs.
Needed to unblock #257.