Disable HttpClient's timeout for Standard Resilience and Hedging #5363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disables HttpClient Timeout for standard resilience and hending handlers
Adds a note mentioning requirements on the Grpc.Net.ClientFactory version to avoid issues with the M.E.Http.Resilience package
iliar-turdushev
commented
Aug 15, 2024
iliar-turdushev
requested review from
martintmk,
RussKie,
joperezr and
geeknoid
RussKie
reviewed
Aug 15, 2024
RussKie
added
the
waiting-author-feedback 📭
martintmk
approved these changes
Aug 23, 2024
Added a target that notifies users that they use a version of the Grpc.Net.ClientFactory package that might cause the dotnet#4924 issue
dotnet-policy-service
bot
removed
the
waiting-author-feedback 📭
Revert changes to the Directory.Build.targets
RussKie
added
the
waiting-author-feedback 📭
Adds a target that checks whether M.E.Http.Resilience package is used together with Grpc.Net.ClientFactory 2.64.0 or later. If not the target warns a user.
dotnet-policy-service
bot
removed
the
waiting-author-feedback 📭
Adds a Known issues section to the doc describing the issue with Grpc.Net.ClientFactory
iliar-turdushev
commented
Sep 2, 2024
...rosoft.Extensions.Http.Resilience/buildTransitive/Microsoft.Extensions.Http.Resilience.props
Outdated
Show resolved
Hide resolved
iliar-turdushev
commented
Sep 2, 2024
RussKie
reviewed
Sep 2, 2024
...rosoft.Extensions.Http.Resilience/buildTransitive/Microsoft.Extensions.Http.Resilience.props
Outdated
Show resolved
Hide resolved
...rosoft.Extensions.Http.Resilience/buildTransitive/Microsoft.Extensions.Http.Resilience.props
Outdated
Show resolved
Hide resolved
src/Libraries/Microsoft.Extensions.Http.Resilience/Microsoft.Extensions.Http.Resilience.csproj
Show resolved
Hide resolved
RussKie
added
the
waiting-author-feedback 📭
* Moves the contents of the .props file into the .targets file * For net462 we now import the contents of the .targets file instead of setting it as a CDATA value in the .csproj file
dotnet-policy-service
bot
removed
the
waiting-author-feedback 📭
RussKie
reviewed
Sep 3, 2024
src/Libraries/Microsoft.Extensions.Http.Resilience/Microsoft.Extensions.Http.Resilience.csproj
Outdated
Show resolved
Hide resolved
RussKie
reviewed
Sep 3, 2024
src/Libraries/Microsoft.Extensions.Http.Resilience/Microsoft.Extensions.Http.Resilience.csproj
Outdated
Show resolved
Hide resolved
Replaces the name of the project file with the MSBuildProjectName variable
dariusclay
reviewed
Sep 3, 2024
dariusclay
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
For doc changes I leave it up to @IEvangelist to confirm, otherwise everything looks good
IEvangelist
approved these changes
Sep 3, 2024
RussKie
added
the
waiting-author-feedback 📭
* Add conditions to pack buildTransitive .targets for net462 only when net462 is included as a target framework * Changed the documentation link to the learn.microsoft.com site
dotnet-policy-service
bot
removed
the
waiting-author-feedback 📭
* Applies editorial changes to the Known issues section
iliar-turdushev
commented
Sep 4, 2024
...soft.Extensions.Http.Resilience/buildTransitive/Microsoft.Extensions.Http.Resilience.targets
Outdated
Show resolved
Hide resolved
RussKie
requested changes
Sep 5, 2024
src/Libraries/Microsoft.Extensions.Http.Resilience/Microsoft.Extensions.Http.Resilience.csproj
Outdated
Show resolved
Hide resolved
dotnet-policy-service
bot
added
the
waiting-author-feedback 📭
RussKie
reviewed
Sep 5, 2024
src/Libraries/Microsoft.Extensions.Http.Resilience/Microsoft.Extensions.Http.Resilience.csproj
Outdated
Show resolved
Hide resolved
* Changes the level of the compatibility log messages from Error to Warning * Updates the logic of copying buildTransitive files
dotnet-policy-service
bot
removed
the
waiting-author-feedback 📭
RussKie
reviewed
Sep 6, 2024
src/Libraries/Microsoft.Extensions.Http.Resilience/Microsoft.Extensions.Http.Resilience.csproj
Show resolved
Hide resolved
RussKie
reviewed
Sep 6, 2024
...soft.Extensions.Http.Resilience/buildTransitive/Microsoft.Extensions.Http.Resilience.targets
Outdated
Show resolved
Hide resolved
RussKie
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4770
Resolves #4924
Reintroduces changes made in the following PR #4862. Originally that PR was reverted because of the following bug #4924.
Adds a note to the documentation mentioning the minimal grpc-dotnet version to be used with M.E.Http.Resilience package.
Microsoft Reviewers: Open in CodeFlow