Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a "Known issues" section describing a potential issue with Grpc.Net.ClientFactory library #42476

Merged

Conversation

iliar-turdushev
Copy link
Contributor

@iliar-turdushev iliar-turdushev commented Sep 5, 2024

Summary

The PR adds a "Known issues" section describing a potential issue that can occur when using Microsoft.Extensions.Http.Resilience package together with Grpc.Net.ClientFactory.

The issue was reported here:
dotnet/extensions#4924

We fixed it here:
dotnet/extensions#5363

And we'd like to extend the documentation with information about the issue and how to fix it.

Fixes dotnet/extensions#4924


Internal previews

📄 File 🔗 Preview link
docs/core/resilience/http-resilience.md docs/core/resilience/http-resilience

@dotnet-bot dotnet-bot added this to the September 2024 milestone Sep 5, 2024
@iliar-turdushev iliar-turdushev changed the title Added a "Known issues" section describing potential issue with Grpc.Net.ClientFactory library Added a "Known issues" section describing a potential issue with Grpc.Net.ClientFactory library Sep 5, 2024
@iliar-turdushev iliar-turdushev marked this pull request as ready for review September 5, 2024 14:15
@iliar-turdushev iliar-turdushev requested a review from a team as a code owner September 5, 2024 14:15
@iliar-turdushev
Copy link
Contributor Author

@IEvangelist You already approved this documentation update here. Could you, please, review this PR too? Thank you.

docs/core/resilience/http-resilience.md Outdated Show resolved Hide resolved
docs/core/resilience/http-resilience.md Show resolved Hide resolved
docs/core/resilience/http-resilience.md Outdated Show resolved Hide resolved
docs/core/resilience/http-resilience.md Outdated Show resolved Hide resolved
@IEvangelist IEvangelist merged commit fe96781 into dotnet:main Sep 6, 2024
8 checks passed
@iliar-turdushev iliar-turdushev deleted the iliarturdu/http-resilience-doc branch September 7, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The ConfigureHttpClient method is not supported when creating gRPC clients.
3 participants