Fix repo reference in az Dockerfile #1071
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build for the changes from #1068 is failing because of the
--registry-override
option that is used. (This didn't fail in the PR build because that option is not used for the build.) The Dockerfile.az.linux file had hardcoded the image names it referenced in itsFROM
instructions. In conjunction with the--registry-override
option, it caused Image Builder to rewrite the file to apply the override. But it generated aFROM
instruction like this:FROM dotnetdocker.azurecr.io/dotnet-buildtools/image-builder:linux-$ARCHAS az-installer
. Note the lack of a space between$ARCH
andAS
. This isn't valid syntax so the build failed.We shouldn't be having the Dockerfile be rewritten with the registry option. We want to keep the exact version that exists in the repo. To fix this, we can replace the repo reference in the Dockerfile with a reference to an
ARG
that is dynamically set within the manifest file. This follows the same convention that is used in the manifest of https://github.com/dotnet/dotnet-docker.