Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repo reference in az Dockerfile #1071

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Conversation

mthalman
Copy link
Member

The build for the changes from #1068 is failing because of the --registry-override option that is used. (This didn't fail in the PR build because that option is not used for the build.) The Dockerfile.az.linux file had hardcoded the image names it referenced in its FROM instructions. In conjunction with the --registry-override option, it caused Image Builder to rewrite the file to apply the override. But it generated a FROM instruction like this: FROM dotnetdocker.azurecr.io/dotnet-buildtools/image-builder:linux-$ARCHAS az-installer. Note the lack of a space between $ARCH and AS. This isn't valid syntax so the build failed.

We shouldn't be having the Dockerfile be rewritten with the registry option. We want to keep the exact version that exists in the repo. To fix this, we can replace the repo reference in the Dockerfile with a reference to an ARG that is dynamically set within the manifest file. This follows the same convention that is used in the manifest of https://github.com/dotnet/dotnet-docker.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@mthalman mthalman merged commit 4c6923e into dotnet:main Oct 26, 2022
@mthalman mthalman deleted the imagebuilder-repo branch October 26, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants