Define version of Image Builder image with Azure CLI installed #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Converted to draft. Need to make some more changes here. |
MichaelSimons
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to implement dotnet/dotnet-docker#4139, we need the ability to authenticate to the internal ACR. This requires the use of the Azure CLI to be able to authenticate into Azure with a certificate.
Installing the Azure CLI adds 1 GB to the image size, a 270% increase over the original image size of Image Builder. The large install size is already tracked by Azure/azure-cli#7387. Given that the use of the Azure CLI is only needed in scenarios to target internal builds, it doesn't seem like a good idea to have it installed for the Image Builder image used everywhere.
With these changes, I've defined a separate image that adds the Azure CLI to the base Image Builder image. This will allow the pipeline runs that target public builds to not be subjected to the very large image size. It will only be relevant for runs that target internal builds.