This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Changes for building using VS2015 #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
force-pushed
the
warnings
branch
2 times, most recently
from
2252147
to
a2b709c
Compare
| generation_allocation_pointer (consing_gen), generation_allocation_limit (consing_gen))); | ||
| generation_plan_allocation_start (consing_gen), | ||
| generation_allocation_pointer (consing_gen), | ||
| generation_allocation_limit (consing_gen))); | ||
| } |
|
fmodf - fixed. I have also cleanup how fabsf is done in the PAL while I was on it. |
|
@janvorli Could you please take a look? |
|
@jkotas fmodf changes broke the Linux build. Once that's resolve this LGTM |
|
LGTM |
jkotas
force-pushed
the
warnings
branch
2 times, most recently
from
632ae07
to
8c4e64e
Compare
jkotas
added a commit
that referenced
this pull request
May 7, 2015
Changes for building using VS2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assorted set of changes to make build produce coreclr.dll using VS2015 successfully. Fixes #824.
More fixes are needed in the managed part of the build to make build work end to end on VS2015.