Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings reported by VS 2015 #4181

Closed
DickvdBrink opened this issue Apr 26, 2015 · 1 comment · Fixed by dotnet/coreclr#949
Closed

Fix warnings reported by VS 2015 #4181

DickvdBrink opened this issue Apr 26, 2015 · 1 comment · Fixed by dotnet/coreclr#949
Assignees

Comments

@DickvdBrink
Copy link
Contributor

Fix warnings reported by VS 2015 - blocks #3862

In total there are currently 2085 warnings but some of them are reported multiple times on the same location so it is not that bad :)

We can also disable them but that might not be wise (at least not for all of them :))

Could not find a msdn link for this one
Warning C4463 overflow; assigning 1 to bit-field that can only hold values from -1 to 0

metamodelrw.cpp#L2755
metamodelrw.cpp#L3173
metamodelrw.cpp#L3359

Warning C4312
This warning detects an attempt to assign a 32-bit value to a 64-bit pointer type, for example, casting a 32-bit int or long to a 64-bit pointer

To much of this one to list but some of them:
'<function-style-cast>': conversion from 'const int' to 'IMDInternalImport *' of greater size cee_dac
holder.h#L659

And similar

Warning C4311
This warning detects 64-bit pointer truncation issues. For example, if code is compiled for a 64-bit architecture, the value of a pointer (64 bits) will be truncated if it is assigned to an int (32 bits). For more information
simplerhash.h#L450

Warning C4302
The compiler detected a conversion from a larger type to a smaller type. Information may be lost
simplerhash.h#L450

@jkotas jkotas self-assigned this May 7, 2015
@jkotas
Copy link
Member

jkotas commented May 7, 2015

I will take care of these.

@msftgits msftgits transferred this issue from dotnet/coreclr Jan 30, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Jan 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants