Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 1913746 #42928

Merged
merged 2 commits into from
Jul 30, 2022

Conversation

dotnet-bot
Copy link
Contributor

This is the pull request automatically created by the OneLocBuild task in the build process to check-in localized files generated based upon translation source files (.lcl files) handed-back from the downstream localization pipeline. If there are issues in translations, visit https://aka.ms/ceLocBug and log bugs for fixes. The OneLocBuild wiki is https://aka.ms/onelocbuild and the localization process in general is documented at https://aka.ms/AllAboutLoc.

@dotnet-bot dotnet-bot requested review from a team and Pilchie as code owners July 26, 2022 18:20
@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jul 26, 2022
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 1904577 Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 1907202 Jul 27, 2022
@dougbu
Copy link
Member

dougbu commented Jul 27, 2022

@jonfortescue is there a way for the loc project to inform the localization team that previous translations were fine but the syntax (an accelerator key in this case) had changed❔ (/cc @vlada-shubina @cristianosuzuki77)

/cc @captainsafia because the #42802 work won't really be complete until this PR is merged w/ real translations.

@dougbu dougbu requested a review from captainsafia July 27, 2022 19:38
@jonfortescue
Copy link
Contributor

@dougbu I don't think so, not without changing it back to the original translation manually at least.

@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 1907202 Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 1909678 Jul 28, 2022
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 1909678 Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 1911998 Jul 29, 2022
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 1911998 Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 1913746 Jul 30, 2022
Copy link
Member

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done 🎉

@dougbu dougbu enabled auto-merge (squash) July 30, 2022 19:45
@dougbu dougbu merged commit a85675d into main Jul 30, 2022
@dougbu dougbu deleted the locfiles/5de63c50-dc75-484e-99fc-72ffb67c83b0 branch July 30, 2022 20:00
@ghost ghost added this to the 7.0-rc1 milestone Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants