-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update templates to incorporate net7 changes #42802
Update templates to incorporate net7 changes #42802
Conversation
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
@captainsafia aren't these changes incomplete w/o removing some of the parameters from template.json files❔ We shouldn't leave dangling bits behind. |
@dougbu this is simply removing lines that are now not required as the framework effectively calls them on your behalf in the cases that the template would have added them before, i.e. the AuthN/AuthZ middleware getting added automatically now if AuthN/AuthZ services are added. |
Got it @DamianEdwards, thanks. I'd resolve my comment if I could 😀 |
Hi @captainsafia. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
cc: @vlada-shubina @phenning for review on the changes related to accelerator keys for the "UseProgramMain" template option. |
...Templates/Web.ProjectTemplates/content/BlazorServerWeb-CSharp/.template.config/template.json
Show resolved
Hide resolved
...lates/content/ComponentsWebAssembly-CSharp/.template.config/localize/templatestrings.en.json
Show resolved
Hide resolved
src/ProjectTemplates/Web.ProjectTemplates/content/RazorPagesWeb-CSharp/Program.Main.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The template (cs
files) changes look good for me; however, I don't know enough to review if the json
changes are correct or not :)
...lates/content/ComponentsWebAssembly-CSharp/.template.config/localize/templatestrings.en.json
Outdated
Show resolved
Hide resolved
…bAssembly-CSharp/.template.config/localize/templatestrings.en.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change related to accelerator key looks good to me
@phenning Do you mind giving this a green light if you're fine with the changes made? |
@deepchoudhery @zahalzel - Tagging so that you can make the related changes to the ASP.NET Core Scaffolding & MS Identity scaffolding templates. |
Hi @vijayrkn. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
@vijayrkn cool already been on it. |
Hi @deepchoudhery. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
Description
UseAuthentication
andUseAuthorization
middleware registration from templatesSwashbuckle.AspNetCore
version to 6.4.0Closes #41893 and #42719
Customer Impact
Over the past few previews, we've been iterating on a feature to automatically register authentication and authorization middlewares when a user has configured authentication schemes or authorization policies. This PR removes the manual registration of these middlewares from the templates and contributes to our overall goal of reducing the amount of boilerplate that users have to write in order to configure authentication.
This PR also updates the
Swashbuckle.AspNetCore
dependency to incorporate code changes that light up the newWithOpenApi
APIs shipping in preview5.Regression?
Risk
Low risk because:
Verification
Packaging changes reviewed?