Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Win10 for ALPN tests #34556

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Require Win10 for ALPN tests #34556

merged 1 commit into from
Jul 20, 2021

Conversation

Tratcher
Copy link
Member

There are new tests that failed on Win8.1 because HTTP/2 isn't supported there. #34242

@Tratcher Tratcher added this to the 6.0-rc1 milestone Jul 20, 2021
@Tratcher Tratcher self-assigned this Jul 20, 2021
@Tratcher Tratcher requested a review from halter73 as a code owner July 20, 2021 17:41
@ghost ghost added the area-runtime label Jul 20, 2021
@Tratcher Tratcher enabled auto-merge (squash) July 20, 2021 17:54
@Tratcher Tratcher merged commit 4c0cb77 into main Jul 20, 2021
@Tratcher Tratcher deleted the tratcher/alpntest branch July 20, 2021 19:54
@Tratcher
Copy link
Member Author

/backport to release/6.0-preview7

@github-actions
Copy link
Contributor

Started backporting to release/6.0-preview7: https://github.com/dotnet/aspnetcore/actions/runs/1050824360

@github-actions
Copy link
Contributor

@Tratcher backporting to release/6.0-preview7 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Require Win10 for ALPN tests
Using index info to reconstruct a base tree...
M	src/Servers/Kestrel/test/InMemory.FunctionalTests/HttpsConnectionMiddlewareTests.cs
Falling back to patching base and 3-way merge...
Auto-merging src/Servers/Kestrel/test/InMemory.FunctionalTests/HttpsConnectionMiddlewareTests.cs
CONFLICT (content): Merge conflict in src/Servers/Kestrel/test/InMemory.FunctionalTests/HttpsConnectionMiddlewareTests.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Require Win10 for ALPN tests
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants