Configure ALPN for callback scenarios #34242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halter73
reviewed
Jul 10, 2021
| listenOptions.UseHttps((_, _, _, _) => | ||
| ValueTask.FromResult(new SslServerAuthenticationOptions() | ||
| { | ||
| ServerCertificate = _x509Certificate2, |
There was a problem hiding this comment.
Can we add a test case confirming that adding
Suggested change
| ServerCertificate = _x509Certificate2, | |
| ServerCertificate = _x509Certificate2, | |
| ApplicationProtocols = new(), |
disables ALPN? Assuming it does ofc.
There was a problem hiding this comment.
It worked on Windows but fails on Ubuntu 😢. I'll file a runtime bug for that. dotnet/runtime#55447
There was a problem hiding this comment.
Fixed in rc1 (main), dotnet/runtime#55772. Waiting for a runtime update.
halter73
approved these changes
Jul 10, 2021
halter73
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31303 by stashing HttpProtocols on TlsHandshakeCallbackOptions just like we did for HttpsConnectionAdapterOptions. If either of the callbacks don't supply ALPN settings then we will. ApplicationProtocols can be set to an empty list to disable ALPN.
Is this too magical?
Is it breaking for people that were using ServerOptionsSelectionCallback and suddenly HTTP/2 starts working?