-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
View details with row click #5000
Conversation
Was wondering if it make sense to dismiss the details when pressing the Esc key. |
I think so. Perhaps clicking the resource a second time hides the details too. |
ESC closing the details view isn't relevant to this PR. Please create a separate issue. |
I see the relevance being that it's now much easier to accidentally open the details pane by clicking in the grid. It's friendly to have escape get things back to "normal". |
They're conceptually related, but this PR is focused on row clicks. If closing with ESC is done, it will be in a different PR. |
Issue for shortcut to close details view: #5050 |
ec5756f
to
2bcc1ac
Compare
@leslierichardson95 Do you have any feedback on this UI change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks good to me! :)
2bcc1ac
to
c087f3d
Compare
Love the interaction this enables 😸 |
Use new OnRowClick feature in FluentUI to show details on pages:
Clickable UI on rows takes precedent. For example, clicking on a resource endpoint URL will launch a new browser to that URL. It doesn't open the detail view.
Changes:
@onclick:stopPropagation="true"
where required. Clicking on UI will bubble the event up until it stops. That means clicking on theView
button triggers the button action and the row click action. The fix is to tell Blazor to stop propagating the event with thestopPropagation
attribute.Demo:

Microsoft Reviewers: Open in CodeFlow