Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close details view with ESC key shortcut #5050

Closed
1 task done
JamesNK opened this issue Jul 24, 2024 · 2 comments
Closed
1 task done

Close details view with ESC key shortcut #5050

JamesNK opened this issue Jul 24, 2024 · 2 comments

Comments

@JamesNK
Copy link
Member

JamesNK commented Jul 24, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.

Details about resources, structured logs and spans are displayed in a details view that opens a new pane on the dashboard.

It might be convient if there if there was a shortcut to close the details view. ESC is the likely canditate.

Describe the solution you'd like

Pressing ESC key while the details view is open closes the details view.

Additional context

No response

@JamesNK
Copy link
Member Author

JamesNK commented Jul 24, 2024

An example is GitHub projects area:

  1. Go to https://github.com/orgs/dotnet/projects/310/views/1?query=sort%3Aupdated-desc+is%3Aopen
  2. Click on an issue. Details are opened in a pane
  3. Pressing ESC key closes the pane

@JamesNK JamesNK changed the title Close details view with ESC Close details view with ESC key shortcut Jul 25, 2024
@leslierichardson95 leslierichardson95 added this to the Backlog milestone Sep 3, 2024
@JamesNK
Copy link
Member Author

JamesNK commented Nov 19, 2024

I looked into this. There is already shift + x to close the panel. And esc is already registered to close a bunch of other things (menus, dialogs, selects).

There isn't a way in Fluent UI to ignore a shortcut if it is already processed, so pressing esc would close everything at once.

@JamesNK JamesNK closed this as completed Nov 19, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants