Extract Aspire.Hosting.Kafka.Tests project #4910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributes to dotnet#3185 Contributes to dotnet#4294
dotnet-issue-labeler
bot
added
the
area-integrations
eerhardt
commented
Jul 15, 2024
| @@ -306,25 +306,6 @@ public void EnsureAllRabbitMQManifestTypesHaveVersion0Suffix() | |||
| Assert.Equal("container.v0", server.GetProperty("type").GetString()); | |||
| } | |||
|
|
|||
| [Fact] | |||
| public void EnsureAllKafkaManifestTypesHaveVersion0Suffix() | |||
There was a problem hiding this comment.
I don't think this test adds value over the AddKafkaTests.VerifyManifest test. That test verifies it is a container.v0 resource.
20 tasks
radical
reviewed
Jul 15, 2024
sebastienros
approved these changes
Jul 16, 2024
Yes, I think this is my recommendation going forward. Now that we have these "Functional" tests individually for each resource, I don't think we need the EndToEnd test to cover every individual resource. It just isn't scalable. Instead, I think we get the EndToEnd down to maybe ~5 core resources (a couple database, Redis, and maybe RabbitMQ) and the rest of these Hosting+Component tests are all in the functional tests. It makes the EndToEnd tests more maintainable. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #3185
Contributes to #4294
cc @Alirexaa
Microsoft Reviewers: Open in CodeFlow