Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more test coverage for the WithDataVolume and WithDataBindMount resource extension methods #3185

Closed
DamianEdwards opened this issue Mar 26, 2024 · 2 comments
Closed

Add more test coverage for the WithDataVolume and WithDataBindMount resource extension methods #3185

DamianEdwards opened this issue Mar 26, 2024 · 2 comments
Assignees
@sebastienros @eerhardt
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication testing ☑️

Comments

@DamianEdwards
Copy link
Member

The WithDataVolume and WithDataBindMount resource extension methods added recently could do with more test coverage.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Mar 26, 2024
@DamianEdwards DamianEdwards mentioned this issue Mar 26, 2024
Merged
@mitchdenny mitchdenny added this to the 8.1 milestone Apr 9, 2024
@joperezr
Copy link
Member

This one is dependent on #4468. A big part of the work here is adding cleanup so volumes are cleaned up after test runs.

@eerhardt eerhardt self-assigned this Jul 1, 2024
@sebastienros sebastienros mentioned this issue Jul 9, 2024
Closed
@eerhardt eerhardt mentioned this issue Jul 12, 2024
Merged
This was referenced Jul 13, 2024
Merged
Merged
eerhardt added a commit to eerhardt/aspire that referenced this issue Jul 15, 2024
@eerhardt
Extract Aspire.Hosting.Kafka.Tests project
68869e3 
Contributes to dotnet#3185
Contributes to dotnet#4294
@eerhardt eerhardt mentioned this issue Jul 15, 2024
Merged
eerhardt added a commit that referenced this issue Jul 16, 2024
@eerhardt
Extract Aspire.Hosting.Kafka.Tests project (#4910)
4374062 
* Extract Aspire.Hosting.Kafka.Tests project

Contributes to #3185
Contributes to #4294
eerhardt added a commit to eerhardt/aspire that referenced this issue Jul 16, 2024
@eerhardt
Extract Aspire.Hosting.Valkey.Tests project
37ddbf3 
Contributes to dotnet#3185
Contributes to dotnet#4294
@eerhardt eerhardt mentioned this issue Jul 16, 2024
Merged
radical pushed a commit that referenced this issue Jul 16, 2024
@eerhardt
Extract Aspire.Hosting.Valkey.Tests project (#4930)
6de43ed 
* Extract Aspire.Hosting.Valkey.Tests project

Contributes to #3185
Contributes to #4294

* Respond to PR feedback
@Alirexaa Alirexaa mentioned this issue Jul 21, 2024
Merged
eerhardt added a commit that referenced this issue Jul 22, 2024
@Alirexaa @eerhardt
@radical @sebastienros
Extract Aspire.Hosting.Milvus.Tests project (#4875)
2576de3 
* Extract Aspire.Hosting.Milvus.Tests project

Contributes to #3185
Contributes to #4294

* Update tests/Aspire.Hosting.Milvus.Tests/MilvusFunctionalTests.cs

Co-authored-by: Ankit Jain <radical@gmail.com>

* Update tests/Aspire.Hosting.Milvus.Tests/Aspire.Hosting.Milvus.Tests.csproj

Co-authored-by: Ankit Jain <radical@gmail.com>

* Apply feedback

* remove launch profile

* Remove milvus from the EndToEnd tests

---------

Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
Co-authored-by: Sébastien Ros <sebastienros@gmail.com>
@eerhardt eerhardt modified the milestones: 8.1, 8.2 Jul 22, 2024
This was referenced Jul 22, 2024
Merged
Merged
eerhardt added a commit to eerhardt/aspire that referenced this issue Aug 1, 2024
@eerhardt
Extract Aspire.Hosting.RabbitMQ.Tests project
93c43ac 
Contributes to dotnet#3185
Contributes to dotnet#4294
@eerhardt eerhardt mentioned this issue Aug 1, 2024
Merged
eerhardt added a commit that referenced this issue Aug 1, 2024
@eerhardt
Extract Aspire.Hosting.RabbitMQ.Tests project (#5130)
5a5a0dc 
* Extract Aspire.Hosting.RabbitMQ.Tests project

Contributes to #3185
Contributes to #4294

* Address PR feedback
@eerhardt
Copy link
Member

eerhardt commented Aug 9, 2024

I'm going to close this out as "completed". The only integration package that doesn't have these tests is Aspire.Hosting.Oracle, which is coming in #4943. And half of them are disabled anyway because it doesn't work today. See #5191.

@eerhardt eerhardt closed this as completed Aug 9, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sebastienros sebastienros

@eerhardt eerhardt

Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication testing ☑️
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@DamianEdwards @mitchdenny @sebastienros @eerhardt @joperezr