Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special case time 0 display in trace times #4183

Merged
merged 2 commits into from
May 16, 2024
+7 −1
Merged

Special case time 0 display in trace times #4183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ae78ce
Special case time 0 display in trace times
davidebbo May 15, 2024
934abbe
Fix duration test to match new expected display
davidebbo May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Aspire.Dashboard/Otlp/Model/DurationFormatter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,12 @@ public static string FormatDuration(TimeSpan duration)
var ofPrevious = primaryUnit.Ticks / secondaryUnit.Ticks;
var ticks = (double)duration.Ticks;

// Special case time 0 to not display any unit, as "0μs" looks quirky
if (ticks == 0)
{
return "0";
}

if (primaryUnit.IsDecimal)
{
// If the unit is decimal based, display as a decimal
Expand Down
2 changes: 1 addition & 1 deletion tests/Aspire.Dashboard.Tests/DurationFormatterTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,6 @@ public void DisplaysTimesLessThanMicroseconds()
public void DisplaysTimesOf0()
{
var input = 0;
Assert.Equal("0μs", DurationFormatter.FormatDuration(TimeSpan.FromTicks(input)));
Assert.Equal("0", DurationFormatter.FormatDuration(TimeSpan.FromTicks(input)));
}
}