Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special case time 0 display in trace times #4183

Merged
merged 2 commits into from
May 16, 2024

Conversation

davidebbo
Copy link
Contributor

@davidebbo davidebbo commented May 15, 2024

This addresses #4107.

Microsoft Reviewers: Open in CodeFlow

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label May 15, 2024
@danmoseley
Copy link
Member

Thanks @davidebbo ..I think I remember working with you in Devdiv? Good to see you.

If you are interested in taking on something larger here, let us know!

@danmoseley danmoseley merged commit 03c6a50 into dotnet:main May 16, 2024
8 checks passed
@danmoseley
Copy link
Member

Btw if you put "fixes #1234" or wherever instead of "this addresses #1234" then GitHub closes the issue with the PR

@davidebbo
Copy link
Contributor Author

Btw if you put "fixes #1234" or wherever instead of "this addresses #1234" then GitHub closes the issue with the PR

@danmoseley Ah right. I had that in the 2ae78ce commit comment, but I guess it needs to be in the PR comment, thanks.

I think I remember working with you in Devdiv? Good to see you.

We certainly did cross paths!

If you are interested in taking on something larger here, let us know!

I started looking at #3456 yesterday after talking to @davidfowl (someone showed interest a while back, but it looks abandoned), so I'm diving into the code to understand things better. Let me know if there are additional interesting ones!

@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-dashboard community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants