Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress 'false positive' credscan violations #3245

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Suppress 'false positive' credscan violations #3245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .config/CredScanSuppressions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,18 @@
{
"placeholder": "fake",
"_justification": "This is fake key name, used in integration tests to try to connect to Azure ServiceBus."
},
{
"placeholder": "TestKey123!",
"_justification": "This is fake API key, used in integration tests to try to connect to OTLP services."
},
{
"placeholder": "!321yeKtseT",
"_justification": "This is fake API key, used in integration tests to try to connect to OTLP services."
},
{
"placeholder": "p@ssw0rd1",
"_justification": "This is fake password, used in integration tests."
}
]
}
4 changes: 2 additions & 2 deletions tests/Aspire.Dashboard.Tests/Integration/StartupTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,15 +75,15 @@ public async Task Configuration_OptionsMonitor_CanReadConfiguration()
additionalConfiguration: initialData =>
{
initialData["Dashboard:Otlp:AuthMode"] = nameof(OtlpAuthMode.ApiKey);
initialData["Dashboard:Otlp:PrimaryApiKey"] = "abc123";
initialData["Dashboard:Otlp:PrimaryApiKey"] = "TestKey123!";
});

// Act
await app.StartAsync();

// Assert
Assert.Equal(OtlpAuthMode.ApiKey, app.DashboardOptionsMonitor.CurrentValue.Otlp.AuthMode);
Assert.Equal("abc123", app.DashboardOptionsMonitor.CurrentValue.Otlp.PrimaryApiKey);
Assert.Equal("TestKey123!", app.DashboardOptionsMonitor.CurrentValue.Otlp.PrimaryApiKey);
}

[Fact]
Expand Down
4 changes: 2 additions & 2 deletions tests/Aspire.Hosting.Tests/RabbitMQ/AddRabbitMQTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public void AddRabbitMQContainerWithDefaultsAddsAnnotationMetadata()
public async Task RabbitMQCreatesConnectionString()
{
var appBuilder = DistributedApplication.CreateBuilder();
appBuilder.Configuration["Parameters:pass"] = "pass1";
appBuilder.Configuration["Parameters:pass"] = "p@ssw0rd1";

var pass = appBuilder.AddParameter("pass");
appBuilder
Expand All @@ -58,7 +58,7 @@ public async Task RabbitMQCreatesConnectionString()
var connectionStringResource = rabbitMqResource as IResourceWithConnectionString;
var connectionString = await connectionStringResource.GetConnectionStringAsync(default);

Assert.Equal("amqp://guest:pass1@localhost:27011", connectionString);
Assert.Equal("amqp://guest:p@ssw0rd1@localhost:27011", connectionString);
Assert.Equal("amqp://guest:{pass.value}@{rabbit.bindings.tcp.host}:{rabbit.bindings.tcp.port}", connectionStringResource.ConnectionStringExpression.ValueExpression);
}

Expand Down
8 changes: 4 additions & 4 deletions tests/Aspire.Hosting.Tests/SqlServer/AddSqlServerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public async Task AddSqlServerContainerWithDefaultsAddsAnnotationMetadata()
public async Task SqlServerCreatesConnectionString()
{
var appBuilder = DistributedApplication.CreateBuilder();
appBuilder.Configuration["Parameters:pass"] = "pass1";
appBuilder.Configuration["Parameters:pass"] = "p@ssw0rd1";

var pass = appBuilder.AddParameter("pass");
appBuilder
Expand All @@ -73,15 +73,15 @@ public async Task SqlServerCreatesConnectionString()
var connectionStringResource = Assert.Single(appModel.Resources.OfType<SqlServerServerResource>());
var connectionString = await connectionStringResource.GetConnectionStringAsync(default);

Assert.Equal("Server=127.0.0.1,1433;User ID=sa;Password=pass1;TrustServerCertificate=true", connectionString);
Assert.Equal("Server=127.0.0.1,1433;User ID=sa;Password=p@ssw0rd1;TrustServerCertificate=true", connectionString);
Assert.Equal("Server={sqlserver.bindings.tcp.host},{sqlserver.bindings.tcp.port};User ID=sa;Password={pass.value};TrustServerCertificate=true", connectionStringResource.ConnectionStringExpression.ValueExpression);
}

[Fact]
public async Task SqlServerDatabaseCreatesConnectionString()
{
var appBuilder = DistributedApplication.CreateBuilder();
appBuilder.Configuration["Parameters:pass"] = "pass2";
appBuilder.Configuration["Parameters:pass"] = "p@ssw0rd1";

var pass = appBuilder.AddParameter("pass");
appBuilder
Expand All @@ -97,7 +97,7 @@ public async Task SqlServerDatabaseCreatesConnectionString()
var connectionStringResource = (IResourceWithConnectionString)sqlResource;
var connectionString = await connectionStringResource.GetConnectionStringAsync();

Assert.Equal("Server=127.0.0.1,1433;User ID=sa;Password=pass2;TrustServerCertificate=true;Database=mydb", connectionString);
Assert.Equal("Server=127.0.0.1,1433;User ID=sa;Password=p@ssw0rd1;TrustServerCertificate=true;Database=mydb", connectionString);
Assert.Equal("{sqlserver.connectionString};Database=mydb", connectionStringResource.ConnectionStringExpression.ValueExpression);
}

Expand Down
Loading