Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress 'false positive' credscan violations #3245

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Suppress 'false positive' credscan violations #3245

merged 1 commit into from
Mar 28, 2024

Conversation

RussKie
Copy link
Member

@RussKie RussKie commented Mar 28, 2024 •
edited
Loading

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-integrations Issues pertaining to Aspire Integrations packages label Mar 28, 2024
@RussKie RussKie added area-engineering-systems infrastructure helix infra engineering repo stuff security 🔐 blocking-clean-ci Blocking a green CI and removed area-integrations Issues pertaining to Aspire Integrations packages labels Mar 28, 2024
@RussKie RussKie enabled auto-merge (squash) March 28, 2024 05:11
@RussKie RussKie merged commit 126b185 into main Mar 28, 2024
8 checks passed
@RussKie RussKie deleted the igveliko/suppress_credscan branch March 28, 2024 07:59
@radical
Copy link
Member

radical commented Mar 28, 2024

@joperezr @RussKie is this needed for 8.0-preview5 branch also?

joperezr
joperezr reviewed Mar 28, 2024
View reviewed changes
Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RussKie

@joperezr
Copy link
Member

I checked with Tactics, and no, it doesn't need t o go into P5.

@radical radical removed the blocking-clean-ci Blocking a green CI label Mar 28, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joperezr joperezr joperezr left review comments

@radical radical radical approved these changes

@JamesNK JamesNK JamesNK approved these changes

@eerhardt eerhardt Awaiting requested review from eerhardt

Assignees
No one assigned
Labels
area-engineering-systems infrastructure helix infra engineering repo stuff security 🔐
Projects
None yet
Milestone
No milestone
4 participants
@RussKie @radical @joperezr @JamesNK