Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to google/bundletool/main@f17ce94a #8135

Merged
merged 6 commits into from
Jun 22, 2023

Commits on Jun 20, 2023

  1. Bump to google/bundletool@f17ce94a

    Context: https://github.com/google/bundletool/releases/tag/1.15.1
    Changes: google/bundletool@1.8.1...1.15.1
    
    We are seeing an error with API 34:
    
        XABBA7024: Xamarin.Tools.Zip.ZipIOException: The file 'obj\Release\android\bin\base.zip' is not a ZIP archive.
    
    We wonder if updating `bundletool` will help. It was last updated in
    989dc07.
    jonathanpeppers committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    e2b763c View commit details
    Browse the repository at this point in the history
  2. [tests] Update ManifestTest.cs

    Context: https://github.com/xamarin/xamarin-android/blob/f1d59181c8daaa8d2abcdfd151b592ece49155ca/src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/ManifestTest.cs#L650-L651
    
    The `ModifyManifest` test actually writes "too much" to the
    `AndroidManifest.xml` file, removing the `<application>` element,
    causing the latest version of `bundletool` to error with:
    
        BT One element <application> was expected, but none were found.
    
    To solve this, let's just set `application:versionCode` in the test
    instead.
    jonathanpeppers committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    43fe871 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. Configuration menu
    Copy the full SHA
    7f214ee View commit details
    Browse the repository at this point in the history
  2. Revert "[tests] Update ManifestTest.cs"

    This reverts commit 43fe871.
    jonathanpeppers committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    f9e4f86 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2e229b8 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. Update ManifestTest.cs

    Work around an MSBuild issue:
    
        error MSB4012: The expression "@(_XmlNodes->'%(Identity)', ' ')@(_Permissions)" cannot be used in this context. Item lists cannot be concatenated with other strings where an item list is expected. Use a semicolon to separate multiple item lists.
    jonathanpeppers committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    a0e0ce0 View commit details
    Browse the repository at this point in the history