Bump to google/bundletool/main@f17ce94a #8135
Conversation
Context: https://github.com/google/bundletool/releases/tag/1.15.1 Changes: google/bundletool@1.8.1...1.15.1 We are seeing an error with API 34: XABBA7024: Xamarin.Tools.Zip.ZipIOException: The file 'obj\Release\android\bin\base.zip' is not a ZIP archive. We wonder if updating `bundletool` will help. It was last updated in 989dc07.
Context: https://github.com/xamarin/xamarin-android/blob/f1d59181c8daaa8d2abcdfd151b592ece49155ca/src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/ManifestTest.cs#L650-L651 The `ModifyManifest` test actually writes "too much" to the `AndroidManifest.xml` file, removing the `<application>` element, causing the latest version of `bundletool` to error with: BT One element <application> was expected, but none were found. To solve this, let's just set `application:versionCode` in the test instead.
| Value=""@(_Permissions)"" | ||
| Query=""/manifest"" | ||
| Value=""12345"" | ||
| Query=""/manifest/@android:versionCode"" |
There was a problem hiding this comment.
This test was failing.
It actually writes "too much" to the AndroidManifest.xml file, removing the <application> element, causing the latest version of bundletool to error with:
BT One element <application> was expected, but none were found.
To solve this, let's just set android:versionCode in the test instead.
There was a problem hiding this comment.
Im not sure this is the best solution. The test in question is replicating a situation a customer reported (and is using). So we should try to figure out why this is not working. I'm not sure how the XmPoke code would remove the application element... unless the behaviour of XmlPoke has changed somehow.
There was a problem hiding this comment.
No, it looks like the test was doing an XmlPoke into the manifest element, which would override the entire contents.
The test itself, seems like it is testing $(AfterGenerateAndroidManifest), so as long as we write something in the manifest with a custom target, and we can read the value at the end: test is the same?
There was a problem hiding this comment.
So the test should be appending the permissions to the manifest element and leaving the rest in place.
If its not doing that then it should be updated to do that somehow.
Having an example of adding permissions using XmlPoke would be a good thing if we can get it working. Since its a use case which a number of users have been doing.
|
Well, the test changes didn't work: Which I guess would have worked with a random Let me actually try it locally... |
Work around an MSBuild issue:
error MSB4012: The expression "@(_XmlNodes->'%(Identity)', ' ')@(_Permissions)" cannot be used in this context. Item lists cannot be concatenated with other strings where an item list is expected. Use a semicolon to separate multiple item lists.
* main: Bump to google/bundletool@f17ce94a (dotnet#8135) [Xamarin.Android.Build.Tasks] Handle IOException in Aapt2Daemon (dotnet#8130) [tests] don't set `/uses-sdk@android:targetSdkVersion=34` by default (dotnet#8138)
* main: Bump to google/bundletool@f17ce94a (dotnet#8135) [Xamarin.Android.Build.Tasks] Handle IOException in Aapt2Daemon (dotnet#8130) [tests] don't set `/uses-sdk@android:targetSdkVersion=34` by default (dotnet#8138)
Context: https://github.com/google/bundletool/releases/tag/1.15.1
Changes: google/bundletool@1.8.1...1.15.1
We are seeing an error with API 34:
We wonder if updating
bundletoolwill help. It was last updated in 989dc07.